linux-kernel - Re: [PATCH v8 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eef43c76-7e1d-4e91-a41a-0a8c33d9616f@kernel.org>
Date: Mon, 28 Jul 2025 06:50:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Friday Yang (杨阳) <Friday.Yang@...iatek.com>,
 "robh@...nel.org" <robh@...nel.org>,
 "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
 Yong Wu (吴勇) <Yong.Wu@...iatek.com>,
 "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
 "conor+dt@...nel.org" <conor+dt@...nel.org>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Project_Global_Chrome_Upstream_Group
 <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v8 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp
 for MT8188

On 28/07/2025 04:59, Friday Yang (杨阳) wrote:
> On Thu, 2025-07-24 at 10:55 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 24/07/2025 10:43, Friday Yang (杨阳) wrote:
>>>>
>>>>> ignore this tag. What I intended to explain here was that I
>>>>> decided
>>>>> not
>>>>> to use 'devm_pm_runtime_enable' to replace 'pm_runtime_enable'
>>>>> functions. Unfortunately, the fake tag didn't explain this
>>>>> clearly
>>>>> in
>>>>> the changelog, which was my fault. To address this, I updated
>>>>> patchset
>>>>> v8 to include an explanation.
>>>>>
>>>>> In patchset v6, I replaced 'pm_runtime_enable' with
>>>>> 'devm_pm_runtime_enable'. However, in patchset v8, I reverted
>>>>> this
>>>>> change and included the reason for this decision in the
>>>>> changelog.
>>>>> Apologize for the delay and the trouble again.
>>>>
>>>> Nothing above is related to my question about the
>>>> fake/invented/questioned tag.
>>>>
>>>
>>> I got your point, you refer to the 'reviewed-by' and 'acked-by' tag
>>> in
>>> this patch.
>>> These are the tags from two reviewers.
>>>
>>>
> https://lore.kernel.org/lkml/174172361378.44650.15345202042780383326.robh@kernel.org/
>>
>>
>> You are really not responding to my initial comments and keep
>> dragging
>> this discussion in some confused directions. Do we talk here about
>> that
>> patch? No.
>>
> 
> I understand what you're referring to. For the 'dt-binding' patch, I
> can keep the tags. However, for the 'smi driver' patch, I should remove
> the tags because there was a change after v6.
> I will update v9 soon. Thank you!


No. You never responded to v7 and never addressed the actual comments I
raised.


Best regards,
Krzysztof