linux-kernel - Re: [PATCH] nvmet: Initialize discovery subsys after debugfs is initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8dfd675-d98c-43b2-8e31-a6d4d4915844@nvidia.com>
Date: Mon, 28 Jul 2025 17:51:25 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Mohamed Khalfella <mkhalfella@...estorage.com>, Christoph Hellwig
	<hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Chaitanya Kulkarni
	<chaitanyak@...dia.com>, Keith Busch <kbusch@...nel.org>
CC: Hannes Reinecke <hare@...nel.org>, Daniel Wagner <dwagner@...e.de>, Randy
 Jennings <randyj@...estorage.com>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nvmet: Initialize discovery subsys after debugfs is
 initialized

On 7/25/25 13:50, Mohamed Khalfella wrote:
> During nvme target initialization discovery subsystem is initialized
> before "nvmet" debugfs directory is created. This results in discovery
> subsystem debugfs directory to be created in debugfs root directory.
>
> nvmet_init() ->
>    nvmet_init_discovery() ->
>      nvmet_subsys_alloc() ->
>        nvmet_debugfs_subsys_setup()
>
> In other words, the codepath above is exeucted before nvmet_debugfs is
> created. We get /sys/kernel/debug/nqn.2014-08.org.nvmexpress.discovery
> instead of /sys/kernel/debug/nvmet/nqn.2014-08.org.nvmexpress.discovery.
> Move nvmet_init_discovery() call after nvmet_init_debugfs() to fix it.
>
> Fixes: 649fd41420a8 ("nvmet: add debugfs support")
> Signed-off-by: Mohamed Khalfella<mkhalfella@...estorage.com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck