linux-kernel - Re: [PATCH v4 3/9] perf annotate: Pass annotation_print_data to annotation_line_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIfE9VWrRzPJD314@google.com>
Date: Mon, 28 Jul 2025 11:44:05 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Arnaldo Carvalho de Melo <acme@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v4 3/9] perf annotate: Pass annotation_print_data to
 annotation_line__write()

On Fri, Jul 25, 2025 at 05:23:00PM -0700, Ian Rogers wrote:
> On Fri, Jul 25, 2025 at 12:38 PM Namhyung Kim <namhyung@...nel.org> wrote:
[SNIP]
> > diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
> > index 0f640e4871744262..8fad464a870a2b8e 100644
> > --- a/tools/perf/util/annotate.h
> > +++ b/tools/perf/util/annotate.h
> > @@ -199,8 +199,18 @@ struct annotation_write_ops {
> >         void (*write_graph)(void *obj, int graph);
> >  };
> >
> > +struct annotation_print_data {
> > +       struct hist_entry *he;
> > +       struct evsel *evsel;
> > +       struct arch *arch;
> > +       struct debuginfo *dbg;
> > +       u64 start;
> > +       int addr_fmt_width;
> > +};
> 
> nit: As the scope of this is now global, is it worth commenting it?
> For example, where is start relative to?

Sure, I'll add comments.

> 
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Namhyung