linux-kernel - Re: [PATCH] staging: media: atomisp: Fix indentation and styling in output kernel code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vfq6P2osMc5A5TZ5Usgyc7mFGNme6TmCQugTE1=8c1zAg@mail.gmail.com>
Date: Mon, 28 Jul 2025 22:08:50 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: "Darshan R." <rathod.darshan.0896@...il.com>
Cc: hansg@...nel.org, mchehab@...nel.org, gregkh@...uxfoundation.org, 
	sakari.ailus@...ux.intel.com, andy@...nel.org, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev, 
	jogidishank503@...il.com
Subject: Re: [PATCH] staging: media: atomisp: Fix indentation and styling in
 output kernel code

On Mon, Jul 28, 2025 at 9:27 AM Darshan R.
<rathod.darshan.0896@...il.com> wrote:
>
> Updated the formatting of function definitions and if statements to match
> kernel coding standards. This helps with readability and consistency across
> the codebase.
>
> These are non-functional changes aimed at preparing the driver for eventual
> mainline readiness by addressing common checkpatch warnings.

...

>  void
>  ia_css_output_encode(

And what is about the above?

> -    struct sh_css_isp_output_params *to,
> -    const struct ia_css_output_config *from,
> -    unsigned int size)
> +       struct sh_css_isp_output_params *to,
> +       const struct ia_css_output_config *from,
> +       unsigned int size)

...

>  int ia_css_output1_config(struct sh_css_isp_output_isp_config       *to,

Seems too much space between _config and *to.

> -                         const struct ia_css_output1_configuration *from,
> +                         const struct ia_css_output1_configuration *from,
>                           unsigned int size)

...

>  int ia_css_output0_configure(const struct ia_css_binary    *binary,

Ditto.

> -                           const struct ia_css_frame_info *info)
> +                            const struct ia_css_frame_info *info)

...

The rest of the code is also subject to the above comments.

...

Btw, somebody else already submitted the similar changes.


-- 
With Best Regards,
Andy Shevchenko