linux-kernel - RE: [PATCH v3] gpio-mlxbf2: only get IRQ for device instances 0 and 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PH7PR12MB5902EBFCAEE90BF7A0AE8DC6C75AA@PH7PR12MB5902.namprd12.prod.outlook.com>
Date: Mon, 28 Jul 2025 20:24:01 +0000
From: David Thompson <davthompson@...dia.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Bartosz Golaszewski
	<brgl@...ev.pl>
CC: Mika Westerberg <mika.westerberg@...ux.intel.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>, "davem@...emloft.net"
	<davem@...emloft.net>, Asmaa Mnebhi <asmaa@...dia.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>, Shravan Ramani
	<shravankr@...dia.com>
Subject: RE: [PATCH v3] gpio-mlxbf2: only get IRQ for device instances 0 and 3

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Wednesday, July 23, 2025 9:58 AM
> To: Bartosz Golaszewski <brgl@...ev.pl>
> Cc: David Thompson <davthompson@...dia.com>; Mika Westerberg
> <mika.westerberg@...ux.intel.com>; linus.walleij@...aro.org;
> davem@...emloft.net; Asmaa Mnebhi <asmaa@...dia.com>; linux-
> gpio@...r.kernel.org; linux-kernel@...r.kernel.org; stable@...r.kernel.org;
> Shravan Ramani <shravankr@...dia.com>
> Subject: Re: [PATCH v3] gpio-mlxbf2: only get IRQ for device instances 0 and 3
> 
> On Tue, Jul 22, 2025 at 04:52:02PM +0200, Bartosz Golaszewski wrote:
> > On Mon, Jul 21, 2025 at 6:22 PM David Thompson <davthompson@...dia.com>
> wrote:
> > >
> > > The gpio-mlxbf2 driver interfaces with four GPIO controllers, device
> > > instances 0-3. There are two IRQ resources shared between the four
> > > controllers, and they are found in the ACPI table for device
> > > instances 0 and 3.  The driver should not attempt to get an IRQ
> > > resource when probing device instance 1 or 2, otherwise the
> > > following error is logged:
> > >   mlxbf2_gpio MLNXBF22:01: error -ENXIO: IRQ index 0 not found
> 
> ...
> 
> > > -       irq = platform_get_irq(pdev, 0);
> 
> So, why not simply change this to the _optional() call?
> 

Thanks for the tip, Andy.  

I've sent a v4 patch that uses this approach.

Thanks, 
- Dave