linux-kernel - Re: [PATCH] zorro: fix checkpatch error by avoiding assignment in if-statement.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a07b9468-67aa-4e22-86af-817bb3295d1b@wanadoo.fr>
Date: Mon, 28 Jul 2025 22:42:40 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Dishank Jogi <jogidishank503@...il.com>, geert@...ux-m68k.org
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
 darshanrathod475@...il.com
Subject: Re: [PATCH] zorro: fix checkpatch error by avoiding assignment in
 if-statement.

Le 28/07/2025 à 11:34, Dishank Jogi a écrit :
> These changes improve code readability and bring the file
> in line with the Linux kernel coding style.
> 
> No functional changes.
> 
> Signed-off-by: Dishank Jogi <jogidishank503@...il.com>
> ---
>   drivers/zorro/gen-devlist.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/zorro/gen-devlist.c b/drivers/zorro/gen-devlist.c
> index e325c5ce995b..ff4515e02409 100644
> --- a/drivers/zorro/gen-devlist.c
> +++ b/drivers/zorro/gen-devlist.c
> @@ -44,7 +44,8 @@ main(void)
>   
>   	while (fgets(line, sizeof(line)-1, stdin)) {
>   		lino++;
> -		if ((c = strchr(line, '\n')))
> +		c = strchr(line, '\n')

Looks like a trailing ; is missing.

Was this patch compile-tested?

No change is trivial, even if they look so.
Please always compile test your changes.

CJ

> +		if (c)
>   			*c = 0;
>   		if (!line[0] || line[0] == '#')
>   			continue;
> @@ -68,7 +69,8 @@ main(void)
>   					fprintf(devf, "\tPRODUCT(%s,%s,\"", manuf, line+1);
>   					pq(devf, c);
>   					fputs("\")\n", devf);
> -				} else goto err;
> +				} else
> +					goto err;
>   				break;
>   			default:
>   				goto err;