linux-kernel - Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: add LinkStar-H68k-1432v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250728-dashing-discerning-roadrunner-bc8b87@kuoka>
Date: Mon, 28 Jul 2025 07:11:10 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Erik Beck <xunil@...omasoft.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: add
 LinkStar-H68k-1432v1

On Mon, Jul 28, 2025 at 07:07:32AM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2025 02:03, Erik Beck wrote:
> > Add device tree bindings.
> > 
> > This device:
> >   - Has not been supported previously in the mainline Linux kernel;
> 
> Irrelevant, drop.
> 
> >   - Is a single board travel router made by Seeed, using an rk3568;
> >   - Has four ethernet ports;
> >   - Has four USB ports;
> >   - Has WiFi (MediaTek MT7921e);
> >   - Has a real-time clock (rk809)
> > 
> > Base commit:
> >   - commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 ("tag: v6.16-rc1");
> 
> Irrelevant, drop. This should NEVER be part of commit msg, because it
> makes no sense once applied. It is not even true in that moment.

Also now I see checkpatch warnings...

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof