linux-kernel - Re: [PATCH v12 2/4] leds: add basic support for TI/National Semiconductor LP5812 LED Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507290749.YxykcKRV-lkp@intel.com>
Date: Tue, 29 Jul 2025 07:36:50 +0800
From: kernel test robot <lkp@...el.com>
To: Nam Tran <trannamatk@...il.com>, lee@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, pavel@...nel.org, rdunlap@...radead.org,
	christophe.jaillet@...adoo.fr, krzk+dt@...nel.org, robh@...nel.org,
	conor+dt@...nel.org, corbet@....net, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, Nam Tran <trannamatk@...il.com>
Subject: Re: [PATCH v12 2/4] leds: add basic support for TI/National
 Semiconductor LP5812 LED Driver

Hi Nam,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f09079bd04a924c72d555cd97942d5f8d7eca98c]

url:    https://github.com/intel-lab-lkp/linux/commits/Nam-Tran/dt-bindings-leds-add-TI-National-Semiconductor-LP5812-LED-Driver/20250728-150224
base:   f09079bd04a924c72d555cd97942d5f8d7eca98c
patch link:    https://lore.kernel.org/r/20250728065814.120769-3-trannamatk%40gmail.com
patch subject: [PATCH v12 2/4] leds: add basic support for TI/National Semiconductor LP5812 LED Driver
config: hexagon-randconfig-r073-20250729 (https://download.01.org/0day-ci/archive/20250729/202507290749.YxykcKRV-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project 1b4db78d2eaa070b3f364a2d2b2b826a5439b892)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507290749.YxykcKRV-lkp@intel.com/

New smatch warnings:
drivers/leds/rgb/leds-lp5812.c:920 lp5812_probe() warn: inconsistent indenting

Old smatch warnings:
drivers/leds/rgb/leds-lp5812.c:467 lp5812_multicolor_brightness() error: uninitialized symbol 'ret'.

vim +920 drivers/leds/rgb/leds-lp5812.c

   903	
   904	static int lp5812_probe(struct i2c_client *client)
   905	{
   906		struct lp5812_chip *chip;
   907		struct device_node *np = dev_of_node(&client->dev);
   908		struct lp5812_led *led;
   909		int ret;
   910	
   911		if (!np)
   912			return -EINVAL;
   913	
   914		chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
   915		if (!chip)
   916			return -ENOMEM;
   917	
   918		chip->cfg = i2c_get_match_data(client);
   919		ret = lp5812_of_populate_pdata(&client->dev, np, chip);
 > 920			if (ret)
   921				return ret;
   922	
   923		led = devm_kcalloc(&client->dev, chip->num_channels, sizeof(*led), GFP_KERNEL);
   924		if (!led)
   925			return -ENOMEM;
   926	
   927		chip->client = client;
   928		mutex_init(&chip->lock);
   929		i2c_set_clientdata(client, led);
   930	
   931		ret = lp5812_init_device(chip);
   932		if (ret)
   933			return ret;
   934	
   935		ret = lp5812_register_leds(led, chip);
   936		if (ret)
   937			goto err_out;
   938	
   939		ret = lp5812_register_sysfs(chip);
   940		if (ret)
   941			goto err_out;
   942	
   943		return 0;
   944	
   945	err_out:
   946		lp5812_deinit_device(chip);
   947		return ret;
   948	}
   949	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki