linux-kernel - Re: [PATCH v3] kconfig/lxdialog: replace strcpy() with strncpy() in inputbox.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAO9wTFi7ejkMbtT80EB2AAOQp7fi+GEf1eJWwfj4j6xU0iEhaQ@mail.gmail.com>
Date: Mon, 28 Jul 2025 11:09:30 +0530
From: Suchit K <suchitkarunakaran@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: masahiroy@...nel.org, nicolas.schier@...ux.dev, 
	linux-kbuild@...r.kernel.org, skhan@...uxfoundation.org, 
	linux-kernel-mentees@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] kconfig/lxdialog: replace strcpy() with strncpy() in inputbox.c

Resending because I unknowingly disabled plain text mode. Sorry about that.

>
> Is strcpy() being deprecated in userspace?  I think it's a core part of
> the C language specification :)
>

My apologies. I was under the assumption that all folders within the
kernel repository adhered to the kernel coding guidelines, only to
realize that these guidelines primarily apply to kernel space code.
You're right, strcpy() isn't deprecated in userspace but as far as I
know some compilers emit warnings to replace it with other functions
since it's unsafe.

> Again, how can that buffer be "too large"?
>

Tbh I'm not sure. I was glancing through the code in mconf.c and there
were some calls to dialog_inputbox() with file names and a variable
length string being passed for the init argument. So, I thought there
might be some chance of overflowing.