linux-kernel - Re: [PATCH] xen: Rename xenmem_reservation_increase to xenmem_populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9d19009-0597-4c5c-8214-ce6593f5330a@suse.com>
Date: Mon, 28 Jul 2025 07:50:15 +0200
From: Jürgen Groß <jgross@...e.com>
To: Teddy Astie <teddy.astie@...es.tech>, xen-devel@...ts.xenproject.org,
 linux-kernel@...r.kernel.org
Cc: Stefano Stabellini <sstabellini@...nel.org>,
 Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
Subject: Re: [PATCH] xen: Rename xenmem_reservation_increase to
 xenmem_populate_physmap

On 25.07.25 12:12, Teddy Astie wrote:
> xenmem_reservation_increase currently calls XENMEM_populate_physmap.
> Rename the function to avoid confusion with XENMEM_increase_reservation.

Hmm, I'm not convinced this is a good move.

xenmem_reservation_increase() has the counterpart xenmem_reservation_decrease(),
which shouldn't change its name.

So for the caller the naming is consistent. It is just the implementation which
is using a different hypercall. IMO such a detail should not be propagated to
higher logical levels.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3684 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)