linux-kernel - Re: [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ flag with a define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3be5c56c-f2cf-4ade-a77c-ace556119f96@gmail.com>
Date: Mon, 28 Jul 2025 09:30:05 +0300
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>,
 Nuno Sá <nuno.sa@...log.com>,
 Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Lucas Stankus <lucas.p.stankus@...il.com>,
 Puranjay Mohan <puranjay@...nel.org>, Dan Robertson <dan@...obertson.com>,
 Marcelo Schmitt <marcelo.schmitt@...log.com>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Dragos Bogdan <dragos.bogdan@...log.com>,
 Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@....com>,
 Ondřej Jirman <megi@....cz>,
 Alexandru Tachici <alexandru.tachici@...log.com>,
 Stefan Popa <stefan.popa@...log.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Stephan Gerhold <stephan@...hold.net>,
 Ceclan Dumitru <dumitru.ceclan@...log.com>,
 Alexandru Lazar <alazar@...rtmail.com>, Andy Gross <agross@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Angelo Compagnucci <angelo.compagnucci@...il.com>,
 Mike Looijmans <mike.looijmans@...ic.nl>, David Heidelberg <david@...t.cz>,
 Manivannan Sadhasivam <mani@...nel.org>,
 Peter Meerwald-Stadler <pmeerw@...erw.net>,
 Andreas Klinger <ak@...klinger.de>, linux-iio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: iio: adc: Replace hard-coded GPIO/IRQ
 flag with a define

On 24/07/2025 14:13, Krzysztof Kozlowski wrote:
> For readability use known defines instead of hard-coding GPIO or
> interrupt flag.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

FWIW:
Acked-by: Matti Vaittinen <mazziesaccount@...il.com>

Thanks!

> ---
>   Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml | 2 +-
>   Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml  | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
> index ef8d51e74c08..592854766583 100644
> --- a/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml
> @@ -63,6 +63,6 @@ examples:
>               vdd-supply = <&adc_vdd>;
>               vref-supply = <&adc_vref>;
>               spi-max-frequency = <1000000>;
> -            shutdown-gpios = <&gpio 26 1>;
> +            shutdown-gpios = <&gpio 26 GPIO_ACTIVE_LOW>;
>           };
>       };
> diff --git a/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml b/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
> index 503285823376..4a8f127de7e3 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rohm,bd79124.yaml
> @@ -81,7 +81,7 @@ examples:
>               reg = <0x10>;
>   
>               interrupt-parent = <&gpio1>;
> -            interrupts = <29 8>;
> +            interrupts = <29 IRQ_TYPE_LEVEL_LOW>;
>   
>               vdd-supply = <&dummyreg>;
>               iovdd-supply = <&dummyreg>;