linux-kernel - Re: [PATCH] platform/x86: surfacepro3_button: replace deprecated strcpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bba2ead6-5c08-4319-b073-198d5a3dad79@intel.com>
Date: Mon, 28 Jul 2025 09:47:15 +0800
From: "Chen, Yu C" <yu.c.chen@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Miguel García <miguelgarciaroman8@...il.com>
CC: <platform-driver-x86@...r.kernel.org>, LKML
	<linux-kernel@...r.kernel.org>, <hansg@...nel.org>,
	<luzmaximilian@...il.com>, <skhan@...uxfoundation.org>, Andy Shevchenko
	<andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH] platform/x86: surfacepro3_button: replace deprecated
 strcpy() with strscpy()

On 7/28/2025 4:32 AM, Ilpo Järvinen wrote:
> On Thu, 24 Jul 2025, Miguel García wrote:
> 
>> strcpy() is deprecated for NUL-terminated strings. Replace it with
>> strscpy() to guarantee NUL-termination. 'name' is a fixed-size local
>> buffer.
>>
>> Signed-off-by: Miguel García <miguelgarciaroman8@...il.com>
>> ---
>>   drivers/platform/surface/surfacepro3_button.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/surface/surfacepro3_button.c b/drivers/platform/surface/surfacepro3_button.c
>> index 2755601f979c..9616548283a1 100644
>> --- a/drivers/platform/surface/surfacepro3_button.c
>> +++ b/drivers/platform/surface/surfacepro3_button.c
>> @@ -211,7 +211,7 @@ static int surface_button_add(struct acpi_device *device)
>>   	}
>>   
>>   	name = acpi_device_name(device);
>> -	strcpy(name, SURFACE_BUTTON_DEVICE_NAME);
>> +	strscpy(name, SURFACE_BUTTON_DEVICE_NAME, sizeof(name));
> 
> strscpy() should nowadays support 2 args variant through clever macro
> trickery.
> 

Yup,  something like
strscpy(name, SURFACE_BUTTON_DEVICE_NAME);
should be fine, because
name is a array, and SURFACE_BUTTON_DEVICE_NAME is smaller than
the size of name.

thanks,
Chenyu