linux-kernel - Re: [PATCH 1/2] input: Add tracepoint support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CBABEDA11FA3B6EF+c3f78605-e0d3-4a4d-a268-4af81422c071@uniontech.com>
Date: Mon, 28 Jul 2025 14:51:39 +0800
From: WangYuli <wangyuli@...ontech.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: dmitry.torokhov@...il.com, guanwentao@...ontech.com,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, mathieu.desnoyers@...icios.com,
 mhiramat@...nel.org, niecheng1@...ontech.com, wangyuli@...pin.org,
 zhanjun@...ontech.com, Winston Wen <wentao@...ontech.com>
Subject: Re: [PATCH 1/2] input: Add tracepoint support

Hi Steve,

On 2025/7/23 08:25, Steven Rostedt wrote:
>> +	TP_STRUCT__entry(__string(name, dev->name ?: "unknown") __field(
>> +		unsigned int, type) __field(unsigned int, code)
>> +				 __field(int, value) __field(u16, bustype)
>> +					 __field(u16, vendor)
>> +						 __field(u16, product)),
>> +
> The contents of the tracepoints in the subsystems are determined by the
> subsystem maintainers, but please follow the tracepoint formatting. The
> above is horrible. It should look like a structure layout. One wouldn't
> write:
>
> struct entry { char *name;
> 		unsigned int type; unsigned int code;
> 			int value; u16 bustype;
> 				u16 vendor;
> 					u16 product; };
>
> That's what the above looks like. It should be instead:
>
> 	TP_STRUCT__entry(
> 		__string(	name,		dev->name ?: "unknown"	)
> 		__field(	unsigned int,	type			)
> 		__field(	unsigned int,	code			)
> 		__field(	int,		value			)
> 		__field(	u16,		bustype			)
> 		__field(	u16,		vendor			)
> 		__field(	u16,		product			)
> 	),
>
> So the fields can be easily visible and easily reviewed.

My apologies.

Since this was a new file I added, I didn't carefully check it after 
applying clang-format, which led to this issue.

I'll fix the code formatting and send a patch v2.

-- 
WangYuli*
*

Download attachment "OpenPGP_0xC5DA1F3046F40BEE.asc" of type "application/pgp-keys" (633 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)