linux-kernel - Re: [PATCH 3/4] agents: add coding style documentation and rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202507271939.D78EC559@keescook>
Date: Sun, 27 Jul 2025 19:40:36 -0700
From: Kees Cook <kees@...nel.org>
To: Sasha Levin <sashal@...nel.org>
Cc: corbet@....net, linux-doc@...r.kernel.org, workflows@...r.kernel.org,
	josh@...htriplett.org, konstantin@...uxfoundation.org,
	linux-kernel@...r.kernel.org, rostedt@...dmis.org
Subject: Re: [PATCH 3/4] agents: add coding style documentation and rules

On Sun, Jul 27, 2025 at 03:58:01PM -0400, Sasha Levin wrote:
> +++ b/Documentation/agents/coding-style.rst

All of this is redundant.

> +**No trailing whitespaces**
> +  Never leave whitespace at the end of lines. Git will warn about patches that introduce trailing whitespace.

If this isn't covered elsewhere in Documentation/, it should be. :)
Also, "all files end with a newline"

> +**80 character line limit**
> +  The preferred limit on the length of a single line is 80 columns. Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information.

And this is why redundancy is bad: our line limit is 100, not 80.

-- 
Kees Cook