linux-kernel - Re: [PATCH v4 01/14] net: ionic: Create an auxiliary device for rdma driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14c50407-9b0a-e3ab-8c62-2943b8592bb2@amd.com>
Date: Mon, 28 Jul 2025 15:47:31 +0530
From: Abhijit Gangurde <abhijit.gangurde@....com>
To: Shannon Nelson <sln@...main.com>, shannon.nelson@....com,
 brett.creeley@....com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, corbet@....net, jgg@...pe.ca,
 leon@...nel.org, andrew+netdev@...n.ch
Cc: allen.hubbe@....com, nikhil.agarwal@....com, linux-rdma@...r.kernel.org,
 netdev@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 01/14] net: ionic: Create an auxiliary device for rdma
 driver


On 7/23/25 23:41, Shannon Nelson wrote:
> On 7/23/25 10:31 AM, Abhijit Gangurde wrote:
>> To support RDMA capable ethernet device, create an auxiliary device in
>> the ionic Ethernet driver. The RDMA device is modeled as an auxiliary
>> device to the Ethernet device.
>>
>> Reviewed-by: Shannon Nelson <shannon.nelson@....com>
>> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@....com>
>> ---
>>   drivers/net/ethernet/pensando/Kconfig         |  1 +
>>   drivers/net/ethernet/pensando/ionic/Makefile  |  2 +-
>>   .../net/ethernet/pensando/ionic/ionic_api.h   | 21 ++++
>>   .../net/ethernet/pensando/ionic/ionic_aux.c   | 95 +++++++++++++++++++
>>   .../net/ethernet/pensando/ionic/ionic_aux.h   | 10 ++
>>   .../ethernet/pensando/ionic/ionic_bus_pci.c   |  5 +
>>   .../net/ethernet/pensando/ionic/ionic_lif.c   |  7 ++
>>   .../net/ethernet/pensando/ionic/ionic_lif.h   |  3 +
>>   8 files changed, 143 insertions(+), 1 deletion(-)
>>   create mode 100644 drivers/net/ethernet/pensando/ionic/ionic_api.h
>>   create mode 100644 drivers/net/ethernet/pensando/ionic/ionic_aux.c
>>   create mode 100644 drivers/net/ethernet/pensando/ionic/ionic_aux.h
>
> Hi Abhijit,
>
> It occurred to me that there should be some discussion added into the 
> ionic.rst file about this new auxiliary_device support.  You might 
> look in the amd/pds_core.rst and mellanox/mlx5/switchdev.rst files for 
> similar examples.  This perhaps isn't a blocker for this patchset, but 
> should be planned soon, or added if you do another rev for other reasons.
>
> (In a similar vein, the pds_core.rst should be updated for the new 
> pds_core.fwctl auxiliary_device, but that's a different problem)
>
> sln

Thanks Shannon. I will mention the rdma support via auxiliary device in 
the ionic.rst in next spin.

Abhijit