linux-kernel - Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support of recovery and coredump process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZBc2X6Yn0X+RbJ9-OSxovnHvoqJ3NXsJKBkuH82GNSAHA@mail.gmail.com>
Date: Mon, 28 Jul 2025 13:39:38 +0300
From: Daniel Baluta <daniel.baluta@...il.com>
To: Shengjiu Wang <shengjiu.wang@....com>
Cc: andersson@...nel.org, mathieu.poirier@...aro.org, shawnguo@...nel.org, 
	s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, 
	linux-remoteproc@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] remoteproc: imx_dsp_rproc: Add support of recovery and
 coredump process

On Tue, Jul 22, 2025 at 11:16 AM Shengjiu Wang <shengjiu.wang@....com> wrote:
>
> When enabled FW recovery, but is broken because software reset is missed
> in this recovery flow. So move software reset from
> imx_dsp_runtime_resume() to .load() and clear memory before loading
> firmware to make recovery work.
>
> Add call rproc_coredump_set_elf_info() to initialize the elf info for
> coredump, otherwise coredump will report error "ELF class is not set".
>
> Fixes: ec0e5549f358 ("remoteproc: imx_dsp_rproc: Add remoteproc driver for DSP on i.MX")
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>

Changes looks good to me:

Reviewed-by: Daniel Baluta <daniel.baluta@....com>

I've tested it with Zephyr synchronization samples inducing a crash
via debugfs interface. App
can recover correctly.