linux-kernel - Re: [PATCH] kcsan: clean up redundant empty macro arguments in atomic ops.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <aIdkQixt-tfT7IPw@elver.google.com>
Date: Mon, 28 Jul 2025 13:51:30 +0200
From: Marco Elver <elver@...gle.com>
To: Jogi Dishank <jogidishank503@...il.com>
Cc: dvyukov@...gle.com, kasan-dev@...glegroups.com,
	linux-kernel@...r.kernel.org, rathod.darshan.0896@...il.com
Subject: Re: [PATCH] kcsan: clean up redundant empty macro arguments in
 atomic ops.

On Mon, Jul 28, 2025 at 05:11PM +0530, Jogi Dishank wrote:
> Yes, I build the kernel with the change.
> And it's build without any error.

You have to set CONFIG_KCSAN=y

kernel/kcsan/core.c:1270:1: error: too few arguments provided to function-like macro invocation
 1270 | DEFINE_TSAN_ATOMIC_OPS(8);
      | ^
kernel/kcsan/core.c:1261:40: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
      |                                               ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1270:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1270 | DEFINE_TSAN_ATOMIC_OPS(8);
      | ^
kernel/kcsan/core.c:1261:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
      |         ^
kernel/kcsan/core.c:1270:1: error: too few arguments provided to function-like macro invocation
kernel/kcsan/core.c:1262:40: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
      |                                               ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1270:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1270 | DEFINE_TSAN_ATOMIC_OPS(8);
      | ^
kernel/kcsan/core.c:1262:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
      |         ^
kernel/kcsan/core.c:1270:1: error: too few arguments provided to function-like macro invocation
kernel/kcsan/core.c:1263:39: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
      |                                              ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1270:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1270 | DEFINE_TSAN_ATOMIC_OPS(8);
      | ^
kernel/kcsan/core.c:1263:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
      |         ^
kernel/kcsan/core.c:1271:1: error: too few arguments provided to function-like macro invocation
 1271 | DEFINE_TSAN_ATOMIC_OPS(16);
      | ^
kernel/kcsan/core.c:1261:40: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
      |                                               ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1271:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1271 | DEFINE_TSAN_ATOMIC_OPS(16);
      | ^
kernel/kcsan/core.c:1261:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
      |         ^
kernel/kcsan/core.c:1271:1: error: too few arguments provided to function-like macro invocation
kernel/kcsan/core.c:1262:40: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
      |                                               ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1271:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1271 | DEFINE_TSAN_ATOMIC_OPS(16);
      | ^
kernel/kcsan/core.c:1262:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
      |         ^
kernel/kcsan/core.c:1271:1: error: too few arguments provided to function-like macro invocation
kernel/kcsan/core.c:1263:39: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
      |                                              ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1271:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1271 | DEFINE_TSAN_ATOMIC_OPS(16);
      | ^
kernel/kcsan/core.c:1263:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
      |         ^
  CC      lib/crypto/mpi/mpi-cmp.o
kernel/kcsan/core.c:1272:1: error: too few arguments provided to function-like macro invocation
 1272 | DEFINE_TSAN_ATOMIC_OPS(32);
      | ^
kernel/kcsan/core.c:1261:40: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
      |                                               ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1272:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1272 | DEFINE_TSAN_ATOMIC_OPS(32);
      | ^
kernel/kcsan/core.c:1261:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
      |         ^
kernel/kcsan/core.c:1272:1: error: too few arguments provided to function-like macro invocation
kernel/kcsan/core.c:1262:40: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
      |                                               ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1272:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1272 | DEFINE_TSAN_ATOMIC_OPS(32);
      | ^
kernel/kcsan/core.c:1262:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1262 |         DEFINE_TSAN_ATOMIC_RMW(fetch_and, bits);                                                 \
      |         ^
kernel/kcsan/core.c:1272:1: error: too few arguments provided to function-like macro invocation
kernel/kcsan/core.c:1263:39: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
      |                                              ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
kernel/kcsan/core.c:1272:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
 1272 | DEFINE_TSAN_ATOMIC_OPS(32);
      | ^
kernel/kcsan/core.c:1263:2: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1263 |         DEFINE_TSAN_ATOMIC_RMW(fetch_or, bits);                                                  \
      |         ^
kernel/kcsan/core.c:1274:1: error: too few arguments provided to function-like macro invocation
 1274 | DEFINE_TSAN_ATOMIC_OPS(64);
      | ^
kernel/kcsan/core.c:1261:40: note: expanded from macro 'DEFINE_TSAN_ATOMIC_OPS'
 1261 |         DEFINE_TSAN_ATOMIC_RMW(fetch_sub, bits);                                                 \
      |                                               ^
kernel/kcsan/core.c:1193:9: note: macro 'DEFINE_TSAN_ATOMIC_RMW' defined here
 1193 | #define DEFINE_TSAN_ATOMIC_RMW(op, bits, suffix)                                                   \
      |         ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]