linux-kernel - Re: [PATCH v13 07/10] firmware: psci: Implement vendor-specific resets as reboot-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcef34c3-98b4-454c-8138-c73729e17081@kernel.org>
Date: Mon, 28 Jul 2025 13:52:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Shivendra Pratap <shivendra.pratap@....qualcomm.com>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>, Sebastian Reichel <sre@...nel.org>,
 Rob Herring <robh@...nel.org>, Sudeep Holla <sudeep.holla@....com>,
 Souvik Chakravarty <Souvik.Chakravarty@....com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andy Yan <andy.yan@...k-chips.com>,
 Mark Rutland <mark.rutland@....com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>, Arnd Bergmann <arnd@...db.de>,
 Konrad Dybcio <konradybcio@...nel.org>, cros-qcom-dts-watchers@...omium.org,
 Vinod Koul <vkoul@...nel.org>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Mukesh Ojha <mukesh.ojha@....qualcomm.com>,
 Stephen Boyd <swboyd@...omium.org>, Andre Draszik
 <andre.draszik@...aro.org>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 Elliot Berman <quic_eberman@...cinc.com>,
 Srinivas Kandagatla <srini@...nel.org>
Subject: Re: [PATCH v13 07/10] firmware: psci: Implement vendor-specific
 resets as reboot-mode

On 28/07/2025 11:44, Dmitry Baryshkov wrote:
> On Mon, Jul 28, 2025 at 06:53:14AM +0200, Krzysztof Kozlowski wrote:
>> On 27/07/2025 18:24, Shivendra Pratap wrote:
>>> +
>>> +static int __init psci_init_vendor_reset(void)
>>> +{
>>> +	struct reboot_mode_driver *reboot;
>>> +	struct device_node *np;
>>> +	int ret;
>>> +
>>> +	np = of_find_node_by_path("/psci/reboot-mode");
>>
>>
>> Why are you looking by full path, not by compatible? Is the ABI - above
>> path - expressed anywhere?
> 
> PSCI node is required to have a node name of psci, it doesn't have MMIO,

This is true

> so it resides in the root node

This might be or not might be true. It is not defined by ABI. Anyway,
you answered where the ABI would be documented, even though as I said it
is not (/psci is not), but does not answer to first part: why you are
not using compatibles which is always the preferred method?


> and the reboot-mode is defined in the
> previous patch. So, I'd assume, the path is defined.

As I said, path is not. only psci/reboot-mode is.

> 
Best regards,
Krzysztof