linux-kernel - Re: [PATCH v2] staging: media: atomisp: Fix indentation and styling in output kernel code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PN3P287MB182915BF3339329C269573B28B5AA@PN3P287MB1829.INDP287.PROD.OUTLOOK.COM>
Date: Mon, 28 Jul 2025 13:08:32 +0000
From: Tarang Raval <tarang.raval@...iconsignals.io>
To: Darshan R. <rathod.darshan.0896@...il.com>
CC: "mchehab@...nel.org" <mchehab@...nel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "jogidishank503@...il.com"
	<jogidishank503@...il.com>, "hansg@...nel.org" <hansg@...nel.org>
Subject: Re: [PATCH v2] staging: media: atomisp: Fix indentation and styling
 in output kernel code

> > Update formatting of function definitions and if statements to match kernel
> > coding standards. This improves readability and ensures consistency across
> > the codebase.
> > 
> > These are non-functional changes intended to address common checkpatch
> > warnings and prepare the driver for eventual mainline inclusion.
> > 
> > Signed-off-by: Darshan R. <rathod.darshan.0896@...il.com>
> > ---
> 
> Whenever you send a new version of the patch, you should include a changelog
> below the --- line. This helps reviewers easily see what has changed from v1
> to v2.
> 
> I think the following document will be useful for you.
> Link: https://www.kernel.org/doc/Documentation/process/submitting-patches.rst
>   
> >  .../output/output_1.0/ia_css_output.host.c    | 22 ++++++++++---------
> >  1 file changed, 12 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c 
> b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> > index d09365e0c471..4f84c6d3622a 100644
> > --- a/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> > +++ b/drivers/staging/media/atomisp/pci/isp/kernels/output/output_1.0/ia_css_output.host.c
> > @@ -34,9 +34,9 @@ static const struct ia_css_output1_configuration default_output1_configuration
> > 
> >  void
> >  ia_css_output_encode(
> > -    struct sh_css_isp_output_params *to,
> > -    const struct ia_css_output_config *from,
> > -    unsigned int size)
> > +       struct sh_css_isp_output_params *to,
> > +       const struct ia_css_output_config *from,
> > +       unsigned int size)
> 
> It would be better formatted like this:
> 
> void ia_css_output_encode(struct sh_css_isp_output_params *to,
> 			  const struct ia_css_output_config *from,
> 			  unsigned int size)

Sorry — the indentation got messed up in my last message, probably due to
the mail client.

Correct format:
void ia_css_output_encode(struct sh_css_isp_output_params *to,
                          const struct ia_css_output_config *from,
                          unsigned int size)

Best Regards,
Tarang