| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <63a0e35d-8e26-410c-ac44-225c8d8b37a9@linaro.org>
Date: Mon, 28 Jul 2025 14:45:14 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Vikram Sharma <quic_vikramsa@...cinc.com>, rfoss@...nel.org,
todor.too@...il.com, mchehab@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, andersson@...nel.org,
konradybcio@...nel.org, hverkuil-cisco@...all.nl,
cros-qcom-dts-watchers@...omium.org, catalin.marinas@....com, will@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, quic_svankada@...cinc.com,
linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/9] media: qcom: camss: Rename camss-vfe-780.c to
camss-vfe-gen3.c
On 03/07/2025 18:19, Vikram Sharma wrote:
> Rename the file camss-vfe-780.c to camss-vfe-gen3.c to enable
> reuse of VFE logic across multiple SoCs.
>
> The SA8775P SoC includes VFE 690, which is very similar to
> VFE 780, with only minor differences in register bitfields.
> Rename prepares the codebase for supporting additional SoCs
> without duplicating VFE logic.
>
> Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
> ---
> drivers/media/platform/qcom/camss/Makefile | 2 +-
> .../qcom/camss/{camss-vfe-780.c => camss-vfe-gen3.c} | 8 ++++----
> drivers/media/platform/qcom/camss/camss-vfe.h | 2 +-
> drivers/media/platform/qcom/camss/camss.c | 10 +++++-----
> 4 files changed, 11 insertions(+), 11 deletions(-)
> rename drivers/media/platform/qcom/camss/{camss-vfe-780.c => camss-vfe-gen3.c} (96%)
>
> diff --git a/drivers/media/platform/qcom/camss/Makefile b/drivers/media/platform/qcom/camss/Makefile
> index ee869e69521a..76845a456c45 100644
> --- a/drivers/media/platform/qcom/camss/Makefile
> +++ b/drivers/media/platform/qcom/camss/Makefile
> @@ -19,7 +19,7 @@ qcom-camss-objs += \
> camss-vfe-17x.o \
> camss-vfe-480.o \
> camss-vfe-680.o \
> - camss-vfe-780.o \
> + camss-vfe-gen3.o \
> camss-vfe-gen1.o \
> camss-vfe.o \
> camss-video.o \
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe-780.c b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> similarity index 96%
> rename from drivers/media/platform/qcom/camss/camss-vfe-780.c
> rename to drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> index b9812d70f91b..93d16b0951e9 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe-780.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Qualcomm MSM Camera Subsystem - VFE (Video Front End) Module v780 (SM8550)
> + * Qualcomm MSM Camera Subsystem - VFE (Video Front End) Module gen3
> *
> * Copyright (c) 2024 Qualcomm Technologies, Inc.
> */
> @@ -113,14 +113,14 @@ static inline void vfe_reg_update_clear(struct vfe_device *vfe,
> camss_reg_update(vfe->camss, vfe->id, port_id, true);
> }
>
> -static const struct camss_video_ops vfe_video_ops_780 = {
> +static const struct camss_video_ops vfe_video_ops_gen3 = {
> .queue_buffer = vfe_queue_buffer_v2,
> .flush_buffers = vfe_flush_buffers,
> };
>
> static void vfe_subdev_init(struct device *dev, struct vfe_device *vfe)
> {
> - vfe->video_ops = vfe_video_ops_780;
> + vfe->video_ops = vfe_video_ops_gen3;
> }
>
> static void vfe_global_reset(struct vfe_device *vfe)
> @@ -140,7 +140,7 @@ static int vfe_halt(struct vfe_device *vfe)
> return 0;
> }
>
> -const struct vfe_hw_ops vfe_ops_780 = {
> +const struct vfe_hw_ops vfe_ops_gen3 = {
> .global_reset = vfe_global_reset,
> .hw_version = vfe_hw_version,
> .isr = vfe_isr,
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.h b/drivers/media/platform/qcom/camss/camss-vfe.h
> index a23f666be753..02d9162ffd93 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.h
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.h
> @@ -244,7 +244,7 @@ extern const struct vfe_hw_ops vfe_ops_4_8;
> extern const struct vfe_hw_ops vfe_ops_170;
> extern const struct vfe_hw_ops vfe_ops_480;
> extern const struct vfe_hw_ops vfe_ops_680;
> -extern const struct vfe_hw_ops vfe_ops_780;
> +extern const struct vfe_hw_ops vfe_ops_gen3;
>
> int vfe_get(struct vfe_device *vfe);
> void vfe_put(struct vfe_device *vfe);
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 1431e08dc04a..310b5cd8de5f 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -2371,7 +2371,7 @@ static const struct camss_subdev_resources vfe_res_8550[] = {
> .is_lite = false,
> .has_pd = true,
> .pd_name = "ife0",
> - .hw_ops = &vfe_ops_780,
> + .hw_ops = &vfe_ops_gen3,
> .formats_rdi = &vfe_formats_rdi_845,
> .formats_pix = &vfe_formats_pix_845
> }
> @@ -2395,7 +2395,7 @@ static const struct camss_subdev_resources vfe_res_8550[] = {
> .is_lite = false,
> .has_pd = true,
> .pd_name = "ife1",
> - .hw_ops = &vfe_ops_780,
> + .hw_ops = &vfe_ops_gen3,
> .formats_rdi = &vfe_formats_rdi_845,
> .formats_pix = &vfe_formats_pix_845
> }
> @@ -2419,7 +2419,7 @@ static const struct camss_subdev_resources vfe_res_8550[] = {
> .is_lite = false,
> .has_pd = true,
> .pd_name = "ife2",
> - .hw_ops = &vfe_ops_780,
> + .hw_ops = &vfe_ops_gen3,
> .formats_rdi = &vfe_formats_rdi_845,
> .formats_pix = &vfe_formats_pix_845
> }
> @@ -2441,7 +2441,7 @@ static const struct camss_subdev_resources vfe_res_8550[] = {
> .vfe = {
> .line_num = 4,
> .is_lite = true,
> - .hw_ops = &vfe_ops_780,
> + .hw_ops = &vfe_ops_gen3,
> .formats_rdi = &vfe_formats_rdi_845,
> .formats_pix = &vfe_formats_pix_845
> }
> @@ -2463,7 +2463,7 @@ static const struct camss_subdev_resources vfe_res_8550[] = {
> .vfe = {
> .line_num = 4,
> .is_lite = true,
> - .hw_ops = &vfe_ops_780,
> + .hw_ops = &vfe_ops_gen3,
> .formats_rdi = &vfe_formats_rdi_845,
> .formats_pix = &vfe_formats_pix_845
> }
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Powered by blists - more mailing lists