| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <a0c910f2-3c7b-4740-b16b-f1efced107db@linaro.org>
Date: Mon, 28 Jul 2025 15:14:50 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Vikram Sharma <quic_vikramsa@...cinc.com>, rfoss@...nel.org,
todor.too@...il.com, mchehab@...nel.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, andersson@...nel.org,
konradybcio@...nel.org, hverkuil-cisco@...all.nl,
cros-qcom-dts-watchers@...omium.org, catalin.marinas@....com, will@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, quic_svankada@...cinc.com,
linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/7] media: qcom: camss: enable vfe 690 for qcs8300
On 11/07/2025 14:11, Vikram Sharma wrote:
> The vfe in qcs8300 is version 690, it is same as vfe used in
> sa8775p. vfe gen3 have support for vfe 690.
>
> Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
> ---
> .../platform/qcom/camss/camss-vfe-gen3.c | 4 +-
> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
> drivers/media/platform/qcom/camss/camss.c | 180 ++++++++++++++++++
> 3 files changed, 185 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> index a5eddc8c76ae..92ee7c7b8a47 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe-gen3.c
> @@ -13,7 +13,9 @@
> #include "camss-vfe.h"
>
> #define IS_VFE_690(vfe) \
> - (vfe->camss->res->version == CAMSS_8775P ? true : false)
> + ((vfe->camss->res->version == CAMSS_8775P) ||\
> + (vfe->camss->res->version == CAMSS_8300) ?\
> + true : false)
>
> #define BUS_REG_BASE_690 \
> (vfe_is_lite(vfe) ? 0x480 : 0x400)
> diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c
> index 99cbe09343f2..1d40184d7d04 100644
> --- a/drivers/media/platform/qcom/camss/camss-vfe.c
> +++ b/drivers/media/platform/qcom/camss/camss-vfe.c
> @@ -344,6 +344,7 @@ static u32 vfe_src_pad_code(struct vfe_line *line, u32 sink_code,
> case CAMSS_8x96:
> case CAMSS_8250:
> case CAMSS_8280XP:
> + case CAMSS_8300:
> case CAMSS_845:
> case CAMSS_8550:
> case CAMSS_8775P:
> @@ -1974,6 +1975,7 @@ static int vfe_bpl_align(struct vfe_device *vfe)
> case CAMSS_7280:
> case CAMSS_8250:
> case CAMSS_8280XP:
> + case CAMSS_8300:
> case CAMSS_845:
> case CAMSS_8550:
> case CAMSS_8775P:
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index b0fd5fd307a1..abfaa489cc0c 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -2623,6 +2623,186 @@ static const struct camss_subdev_resources csid_res_8300[] = {
> },
> };
>
> +static const struct camss_subdev_resources vfe_res_8300[] = {
> + /* VFE0 */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe0", "vfe0", "vfe0_fast_ahb",
> + "cpas_ahb", "gcc_axi_hf", "gcc_axi_sf",
> + "core_ahb", "cpas_fast_ahb_clk", "camnoc_axi",
> + "icp_ahb"},
> + .clock_rate = {
> + { 0 },
> + { 480000000 },
> + { 300000000, 400000000 },
> + { 300000000, 400000000 },
> + { 0 },
> + { 0 },
> + { 0, 80000000 },
> + { 300000000, 400000000 },
> + { 400000000 },
> + { 0 },
> + },
> + .reg = { "vfe0" },
> + .interrupt = { "vfe0" },
> + .vfe = {
> + .line_num = 3,
> + .is_lite = false,
> + .has_pd = false,
> + .pd_name = NULL,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE1 */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe1", "vfe1", "vfe1_fast_ahb",
> + "cpas_ahb", "gcc_axi_hf", "gcc_axi_sf",
> + "core_ahb", "cpas_fast_ahb_clk", "camnoc_axi",
> + "icp_ahb"},
> + .clock_rate = {
> + { 0 },
> + { 480000000 },
> + { 300000000, 400000000 },
> + { 300000000, 400000000 },
> + { 0 },
> + { 0 },
> + { 0, 80000000 },
> + { 300000000, 400000000 },
> + { 400000000 },
> + { 0 },
> + },
> + .reg = { "vfe1" },
> + .interrupt = { "vfe1" },
> + .vfe = {
> + .line_num = 3,
> + .is_lite = false,
> + .has_pd = false,
> + .pd_name = NULL,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE2 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite0" },
> + .interrupt = { "vfe_lite0" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE3 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite1" },
> + .interrupt = { "vfe_lite1" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE4 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite2" },
> + .interrupt = { "vfe_lite2" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE5 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite3" },
> + .interrupt = { "vfe_lite3" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> + /* VFE6 (lite) */
> + {
> + .regulators = {},
> + .clock = { "cpas_vfe_lite", "vfe_lite_ahb",
> + "vfe_lite_csid", "vfe_lite_cphy_rx",
> + "vfe_lite"},
> + .clock_rate = {
> + { 0, 0, 0, 0 },
> + { 300000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 400000000, 400000000, 400000000, 400000000 },
> + { 480000000, 600000000, 600000000, 600000000 },
> + },
> + .reg = { "vfe_lite4" },
> + .interrupt = { "vfe_lite4" },
> + .vfe = {
> + .line_num = 4,
> + .is_lite = true,
> + .hw_ops = &vfe_ops_gen3,
> + .formats_rdi = &vfe_formats_rdi_845,
> + .formats_pix = &vfe_formats_pix_845
> + }
> + },
> +};
> +
> static const struct camss_subdev_resources csiphy_res_8775p[] = {
> /* CSIPHY0 */
> {
This generally looks fine. Please have a look at your pretty extensive
list of clocks and decide if you really need all of them.
I'll trust you to come back with the appropriate list, perhaps even the
list above.
Powered by blists - more mailing lists