linux-kernel - Re: [PATCH] nvmet: Remove unnecessary assignment to ret in nvmet_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <237cb015-feed-4c9c-a23e-8c3dc25466ba@linux.ibm.com>
Date: Mon, 28 Jul 2025 09:20:52 +0530
From: Nilay Shroff <nilay@...ux.ibm.com>
To: Mohamed Khalfella <mkhalfella@...estorage.com>,
        Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Chaitanya Kulkarni <kch@...dia.com>, Keith Busch <kbusch@...nel.org>
Cc: Hannes Reinecke <hare@...nel.org>,
        Randy Jennings
 <randyj@...estorage.com>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmet: Remove unnecessary assignment to ret in
 nvmet_ns_enable()



On 7/26/25 4:36 AM, Mohamed Khalfella wrote:
> Commit 74d16965d7ac ("nvmet-loop: avoid using mutex in IO hotpath")
> moved checking maximum number of namespaces in subsystem from
> nvmet_ns_enable() to nvmet_ns_alloc(). The assignment to ret in
> nvmet_ns_enable() is no longer needed, remove it.
> 
> Fixex: 74d16965d7ac ("nvmet-loop: avoid using mutex in IO hotpath")
> Signed-off-by: Mohamed Khalfella <mkhalfella@...estorage.com>

Looks good to me:
Reviewed-by: Nilay Shroff <nilay@...ux.ibm.com>