linux-kernel - [RFC PATCH] Replace dev_err with drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250728145841.378172-1-hsukrut3@gmail.com>
Date: Mon, 28 Jul 2025 16:58:28 +0200
From: Sukrut Heroorkar <hsukrut3@...il.com>
To: sean@...rly.run,
	Alex Deucher <alexander.deucher@....com>,
	Christian König <christian.koenig@....com>,
	David Airlie <airlied@...il.com>,
	Simona Vetter <simona@...ll.ch>,
	Victor Skvortsov <Victor.Skvortsov@....com>,
	Hawking Zhang <Hawking.Zhang@....com>,
	Lijo Lazar <lijo.lazar@....com>,
	Srinivasan Shanmugam <srinivasan.shanmugam@....com>,
	Jack Xiao <Jack.Xiao@....com>,
	Tony Yi <Tony.Yi@....com>,
	Mirsad Todorovac <mtodorovac69@...il.com>,
	Sukrut Heroorkar <hsukrut3@...il.com>,
	Shaoyun Liu <shaoyun.liu@....com>,
	amd-gfx@...ts.freedesktop.org (open list:RADEON and AMDGPU DRM DRIVERS),
	dri-devel@...ts.freedesktop.org (open list:DRM DRIVERS),
	linux-kernel@...r.kernel.org (open list)
Cc: skhan@...uxfoundation.org,
	david.hunter.linux@...il.com
Subject: [RFC PATCH] Replace dev_err with drm_err

Hello,

This patch converts  dev_err logging to drm_err, as recommended
in gpu/todo.rst for drivers supporting multiple DRM instances.

Before proceeding further, I'd like to confirm if this is the
right direction for amdgpu.

The below change builds successfully. I am happy to send this
as a formal patch if it's acceptable.

Thank you.

Signed-off-by: Sukrut Heroorkar <hsukrut3@...il.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
index 13f0cdeb59c4..effffba39b5a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
@@ -460,7 +460,7 @@ static int amdgpu_virt_read_pf2vf_data(struct amdgpu_device *adev)
 		return -EINVAL;
 
 	if (pf2vf_info->size > 1024) {
-		dev_err(adev->dev, "invalid pf2vf message size: 0x%x\n", pf2vf_info->size);
+		drm_err(adev_to_drm(adev), "invalid pf2vf message size: 0x%x\n", pf2vf_info->size);
 		return -EINVAL;
 	}
 
@@ -471,7 +471,7 @@ static int amdgpu_virt_read_pf2vf_data(struct amdgpu_device *adev)
 			adev->virt.fw_reserve.p_pf2vf, pf2vf_info->size,
 			adev->virt.fw_reserve.checksum_key, checksum);
 		if (checksum != checkval) {
-			dev_err(adev->dev,
+			drm_err(adev_to_drm(adev),
 				"invalid pf2vf message: header checksum=0x%x calculated checksum=0x%x\n",
 				checksum, checkval);
 			return -EINVAL;
-- 
2.43.0