linux-kernel - Re: [PATCH][next] scsi: scsi_debug: make read-only arrays static const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86f359c3-8eb6-4fd7-8411-12d12e301d61@wanadoo.fr>
Date: Tue, 29 Jul 2025 19:45:55 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Colin Ian King <colin.i.king@...il.com>,
 "James E . J . Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>,
 linux-scsi@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] scsi: scsi_debug: make read-only arrays static
 const

Le 29/07/2025 à 08:49, Colin Ian King a écrit :
> Don't populate the read-only arrays on the stack at run time, instead
> make them static const. Also reduces overall size.
> 
> before:
>     text	   data	    bss	    dec	    hex	filename
>   367439	  89582	   5952	 462973	  7107d	drivers/scsi/scsi_debug.o
> 
> after:
>     text	   data	    bss	    dec	    hex	filename
>   365847	  90702	   5952	 462501	  70ea5	drivers/scsi/scsi_debug.o

Hi,

out of curiosity, any idea why 'data' increase?

All my constification patches lead to data reduction.

> 
> (gcc 14.2.0, x86-64)

(same kind of behavior with 15.1.1)

CJ