linux-kernel - Re: [GIT PULL 09/14 for v6.17] vfs bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ysgjztjbsmjae3g4jybuzlmfljq5zog3eja7augtrjmji5pqw4@n3sc37ynny3t>
Date: Tue, 29 Jul 2025 11:15:56 -0700
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Christian Brauner <brauner@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [GIT PULL 09/14 for v6.17] vfs bpf

On Fri, Jul 25, 2025 at 01:27:15PM +0200, Christian Brauner wrote:
> Hey Linus,
> 
> /* Summary */
> These changes allow bpf to read extended attributes from cgroupfs.
> This is useful in redirecting AF_UNIX socket connections based on cgroup
> membership of the socket. One use-case is the ability to implement log
> namespaces in systemd so services and containers are redirected to
> different journals.
> 
> Please note that I plan on merging bpf changes related to the vfs
> exclusively via vfs trees.

That was not discussed and agreed upon.

> /* Testing */

The selftests/bpf had bugs flagged by BPF CI.

> /* Conflicts */
> 
> Merge conflicts with mainline
> =============================
> 
> No known conflicts.
> 
> Merge conflicts with other trees
> ================================
> 
> No known conflicts.

You were told a month ago that there are conflicts
and you were also told that the branch shouldn't be rebased,
yet you ignored it.

> Christian Brauner (3):
>       kernfs: remove iattr_mutex
>       Merge patch series "Introduce bpf_cgroup_read_xattr"
>       selftests/kernfs: test xattr retrieval
> 
> Song Liu (3):
>       bpf: Introduce bpf_cgroup_read_xattr to read xattr of cgroup's node
>       bpf: Mark cgroup_subsys_state->cgroup RCU safe
>       selftests/bpf: Add tests for bpf_cgroup_read_xattr
> 
>  fs/bpf_fs_kfuncs.c                                 |  34 +++++
>  fs/kernfs/inode.c                                  |  70 ++++-----
>  kernel/bpf/helpers.c                               |   3 +
>  kernel/bpf/verifier.c                              |   5 +
>  tools/testing/selftests/bpf/bpf_experimental.h     |   3 +
>  .../selftests/bpf/prog_tests/cgroup_xattr.c        | 145 +++++++++++++++++++
>  .../selftests/bpf/progs/cgroup_read_xattr.c        | 158 +++++++++++++++++++++
>  .../selftests/bpf/progs/read_cgroupfs_xattr.c      |  60 ++++++++

Now Linus needs to resolve the conflicts again.
More details in bpf-next PR:
https://lore.kernel.org/bpf/20250729180626.35057-1-alexei.starovoitov@gmail.com/