linux-kernel - Re: [PATCH v3 4/5] arm64: dts: rockchip: Add missing dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBOSZZ7TMD2P.U0MGKUR3DXN@cknow.org>
Date: Tue, 29 Jul 2025 21:59:02 +0200
From: "Diederik de Haas" <didi.debian@...ow.org>
To: "Chaoyi Chen" <kernel@...kyi.com>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Vinod Koul" <vkoul@...nel.org>, "Kishon Vijay
 Abraham I" <kishon@...nel.org>, "Heiko Stuebner" <heiko@...ech.de>, "Sandy
 Huang" <hjc@...k-chips.com>, "Andy Yan" <andy.yan@...k-chips.com>, "Yubing
 Zhang" <yubing.zhang@...k-chips.com>, "Frank Wang"
 <frank.wang@...k-chips.com>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "David Airlie"
 <airlied@...il.com>, "Simona Vetter" <simona@...ll.ch>, "Amit Sunil Dhamne"
 <amitsd@...gle.com>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 "Chaoyi Chen" <chaoyi.chen@...k-chips.com>, "Dragan Simic"
 <dsimic@...jaro.org>, "Johan Jonker" <jbx6244@...il.com>, "Dmitry
 Baryshkov" <dmitry.baryshkov@....qualcomm.com>, "Peter Robinson"
 <pbrobinson@...il.com>
Cc: <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-phy@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-rockchip@...ts.infradead.org>, <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v3 4/5] arm64: dts: rockchip: Add missing dp_out port
 for RK3399 CDN-DP

On Tue Jul 29, 2025 at 11:00 AM CEST, Chaoyi Chen wrote:
> From: Chaoyi Chen <chaoyi.chen@...k-chips.com>
>
> Let's make the ports nodes of cdn_dp in the same style as the other
> display interface, and match the style of ports's yaml.
>
> Signed-off-by: Chaoyi Chen <chaoyi.chen@...k-chips.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> index 9d5f5b083e3c..edeb177bc433 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-base.dtsi
> @@ -618,7 +618,11 @@ cdn_dp: dp@...00000 {
>  		status = "disabled";
>  
>  		ports {
> -			dp_in: port {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			dp_in: port@0 {
> +				reg = <0>;
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> @@ -632,6 +636,12 @@ dp_in_vopl: endpoint@1 {
>  					remote-endpoint = <&vopl_out_dp>;
>  				};
>  			};
> +
> +			dp_out: port@1 {
> +				reg = <1>;
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +			};

Patch 5 adds a single endpoint to dp_out (without a reg property), so it
seems that #address/#size-cells is not needed?
If you run ``make CHECK_DTBS=y W=1 rockchip/rk3399-evb-ind.dtb`` it
should spit out a warning about that.

Cheers,
  Diederik

>  		};
>  	};
>  


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)