linux-kernel - Re: [PATCH v4] checkpatch: warn about novice phrases in commit messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <afe999de5fecdeabb291dad9da186073bed386b7.camel@perches.com>
Date: Tue, 29 Jul 2025 13:28:45 -0700
From: Joe Perches <joe@...ches.com>
To: Ignacio Peña <ignacio.pena87@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] checkpatch: warn about novice phrases in commit
 messages

On Tue, 2025-07-29 at 10:07 -0400, Ignacio Peña wrote:
> Add warnings for common phrases that indicate uncertainty or lack of
> confidence in commit messages.
> 
> Signed-off-by: Ignacio Peña <ignacio.pena87@...il.com>
> ---
>  scripts/checkpatch.pl | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

-ENOCHANGELOG

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3430,6 +3430,24 @@ sub process {
>  			     "Use lore.kernel.org archive links when possible - see https://lore.kernel.org/lists.html\n" . $herecurr);
>  		}
>  
> +# Check for novice phrases in commit messages
> +		if ($in_commit_log && !$non_utf8_charset) {
> +			my $novice_phrases = qr{(?:^|\s)(?i)(
> +				I\s+think|
> +				I\s+believe|
> +				I\s+suppose|
> +				probably|
> +				maybe|
> +				perhaps|
> +				possibly|
> +				hopefully

definite nak.

maybe is used way too often.

Where did you get these word choices?

What happened to the "my first kernel patch" phrases?

And you have not ever answered why !$non_utf8_charset is useful.

> +			)(?:\s|$)}x;
> +			if ($line =~ /$novice_phrases/) {

this should be
			if ($line =~ /\b$novice_phrases\b/) {

> +				WARN("NOVICE_PHRASE",
> +				     "Avoid uncertainty phrases like '$1' in commit messages\n" . $herecurr);
> +			}
> +		}
> +
>  # Check for added, moved or deleted files
>  		if (!$reported_maintainer_file && !$in_commit_log &&
>  		    ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||