linux-kernel - Re: [PATCH] selftests: timers: improve adjtick output readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANDhNCpp5DxzRufL9iVj8p0tpNSXG7WPEcTDpLbb2TzrY9HyOw@mail.gmail.com>
Date: Mon, 28 Jul 2025 17:33:59 -0700
From: John Stultz <jstultz@...gle.com>
To: Vishal Parmar <vishistriker@...il.com>
Cc: shuah@...nel.org, anna-maria@...utronix.de, frederic@...nel.org, 
	tglx@...utronix.de, sboyd@...nel.org, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests: timers: improve adjtick output readability

On Mon, Jul 28, 2025 at 9:03 AM Vishal Parmar <vishistriker@...il.com> wrote:
>
> Reformat the output of the `adjtick` test in tools/testing/selftests/timers/
> to display results in a clean tabular format.
>
> Previously, the output was printed in a free-form manner like this:
>
>   Each iteration takes about 15 seconds
>   Estimating tick (act: 9000 usec, -100000 ppm): 9000 usec, -100000 ppm [OK]
>
> This format made it hard to visually compare values across iterations or parse
> results in scripts.
>
> The new output is aligned in a table with clearly labeled columns:
>
>   Each iteration takes about 15 seconds
>    ---------------------------------------------------------------
>    | Requested (usec) | Expected (ppm) | Measured (ppm) | Result  |
>    |------------------|----------------|----------------|---------|
>    | 9000             | -100000        | -100001        | [ OK ]  |
>    | 9250             | -75000         | -75000         | [ OK ]  |
>    ...
>    ---------------------------------------------------------------
>
> This improves readability, consistency, and log usability for automated tooling.

No major objection from me, but also I've not followed too closely if
the kselftest output formatting has been formalized further (I know it
was moving towards TAP), but it seems this test hasn't been converted
yet, so it probably isn't negatively impacting things.

So it might be worth looking into getting the output to be happy with
TAP while you're tweaking things here.

Otherwise,
Acked-by: John Stultz <jstultz@...gle.com>

thanks
-john