linux-kernel - Re: [PATCH 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aIg_5S_Wq6jmhUKV@dixit>
Date: Tue, 29 Jul 2025 08:58:37 +0530
From: Dixit Parmar <dixitparmar19@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: andy@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
	dlechner@...libre.com, jic23@...nel.org, krzk+dt@...nel.org,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	nuno.sa@...log.com, robh@...nel.org
Subject: Re: [PATCH 1/2] iio: magnetometer: add support for Infineon TLV493D
 3D Magentic sensor

On Sun, Jul 27, 2025 at 12:03:59AM +0200, Christophe JAILLET wrote:
> Le 26/07/2025 à 11:37, Dixit Parmar a écrit :
> > The Infineon TLV493D is a Low-Power 3D Magnetic Sensor. The Sensor
> > applications includes joysticks, control elements (white goods,
> > multifunction knops), or electric meters (anti tampering) and any
> > other application that requires accurate angular measurements at
> > low power consumptions.
> 
> Hi,
> 
> > +	ret = read_poll_timeout(regmap_bulk_read, err, err ||
> > +			FIELD_GET(TLV493D_VAL_CHANNEL, buff[TLV493D_RD_REG_TEMP]) == 0,
> > +			mode->sleep_us, (3 * mode->sleep_us), false, data->map, TLV493D_RD_REG_BX,
> > +			buff, ARRAY_SIZE(buff));
> > +	if (ret) {
> > +		dev_err(data->dev, "read poll timeout, error:%d", ret);
> 
> Nitpick: missing trailing \n
>
Ack.
> > +		goto out;
> > +	}
> > +	if (err) {
> > +		dev_err(data->dev, "read data failed, error:%d\n", ret);
> > +		ret = err;
> > +		goto out;
> > +	}
> 
> ...
> 
> > +	ret = tlv493d_init(data);
> > +	if (ret)
> > +		return dev_err_probe(dev, ret, "failed to initialized\n");
> 
> Nitpick: to initialize (without a d)
> 
Ack.
> > +
> > +	indio_dev->info = &tlv493d_info;
> > +	indio_dev->modes = INDIO_DIRECT_MODE;
> 
> ...
> 
> CJ