linux-kernel - Re: [PATCH] ACPI: EC: Ignore ECDT tables with an invalid ID string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <503e471c-be4e-4678-9f9d-c2294b426d2e@gmx.de>
Date: Tue, 29 Jul 2025 07:04:38 +0200
From: Armin Wolf <W_Armin@....de>
To: Ilya K <me@...ti.me>, rafael@...nel.org
Cc: lenb@...nel.org, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: EC: Ignore ECDT tables with an invalid ID string

Am 29.07.25 um 06:29 schrieb Ilya K:

>
> On 2025-07-29 01:13, Armin Wolf wrote:
>> Oh no, that sounds horrible 🙁
>>
>> Can you share the output of "acpidump" once the system is running the latest firmware? If a BIOS update
>> does not solve the issue then we could give the ID string check a more leeway so that only empty strings
>> are considered invalid.
>>
> The firmware update did not, in fact, change anything. Here's the entire ECDT:
>
> [000h 0000 004h]                   Signature : "ECDT"    [Embedded Controller Boot Resources Table]
> [004h 0004 004h]                Table Length : 00000069
> [008h 0008 001h]                    Revision : 01
> [009h 0009 001h]                    Checksum : 6E
> [00Ah 0010 006h]                      Oem ID : "LENOVO"
> [010h 0016 008h]                Oem Table ID : "CB-01   "
> [018h 0024 004h]                Oem Revision : 00000001
> [01Ch 0028 004h]             Asl Compiler ID : "LENO"
> [020h 0032 004h]       Asl Compiler Revision : 00000001
>
>
> [024h 0036 00Ch]     Command/Status Register : [Generic Address Structure]
> [024h 0036 001h]                    Space ID : 01 [SystemIO]
> [025h 0037 001h]                   Bit Width : 08
> [026h 0038 001h]                  Bit Offset : 00
> [027h 0039 001h]        Encoded Access Width : 00 [Undefined/Legacy]
> [028h 0040 008h]                     Address : 0000000000000066
>
> [030h 0048 00Ch]               Data Register : [Generic Address Structure]
> [030h 0048 001h]                    Space ID : 01 [SystemIO]
> [031h 0049 001h]                   Bit Width : 08
> [032h 0050 001h]                  Bit Offset : 00
> [033h 0051 001h]        Encoded Access Width : 00 [Undefined/Legacy]
> [034h 0052 008h]                     Address : 0000000000000062
>
> [03Ch 0060 004h]                         UID : 00000000
> [040h 0064 001h]                  GPE Number : 6E
> [041h 0065 012h]                    Namepath : "_SB.PC00.LPCB.EC0"
>
> Raw Table Data: Length 105 (0x69)
>
>      0000: 45 43 44 54 69 00 00 00 01 6E 4C 45 4E 4F 56 4F  // ECDTi....nLENOVO
>      0010: 43 42 2D 30 31 20 20 20 01 00 00 00 4C 45 4E 4F  // CB-01   ....LENO
>      0020: 01 00 00 00 01 08 00 00 66 00 00 00 00 00 00 00  // ........f.......
>      0030: 01 08 00 00 62 00 00 00 00 00 00 00 00 00 00 00  // ....b...........
>      0040: 6E 5F 53 42 2E 50 43 30 30 2E 4C 50 43 42 2E 45  // n_SB.PC00.LPCB.E
>      0050: 43 30 00 00 00 00 00 00 00 00 00 00 00 00 00 00  // C0..............
>      0060: 00 00 00 00 00 00 00 00 00                       // .........
>
> It is fully identical on both firmware versions I've seen.
>
Alright, seems that we have to give the ID string a bit more leeway. I will prepare a patch for this.

Thanks,
Armin Wolf