linux-kernel - Re: [PATCH] tsacct: Remove unused macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAO9wTFj8d3Toafof0MBvPybfDMsAAuJ4rxrH0EMcVqZZrg0VCA@mail.gmail.com>
Date: Tue, 29 Jul 2025 12:07:46 +0530
From: Suchit Karunakaran <suchitkarunakaran@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: skhan@...uxfoundation.org, linux-kernel@...r.kernel.org, 
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] tsacct: Remove unused macro definition

On Tue, 29 Jul 2025 at 11:22, Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Tue, Jul 29, 2025 at 11:03:59AM +0530, Suchit Karunakaran wrote:
> > The MB macro was defined in tsacct.c but never used, leading to a compiler
> > warning. This patch removes the unused definition to clean up the code and
> > suppress the warning.
>
> What compiler warning shows this?  As part of a normal build?
>

It's not part of the normal build. I built the kernel with C=1 and V=1 flags.

> We have loads of defines that are not used, especially in drivers, are
> we now going to start deleting them all?
>

Agreed, sorry for the inconvenience.