linux-kernel - Re: [PATCH linux-next] signal: Remove outdated __send_signal references in do_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250729150405008DO4Sb1P2U3KuRwnVi6ep7@zte.com.cn>
Date: Tue, 29 Jul 2025 15:04:05 +0800 (CST)
From: <fan.yu9@....com.cn>
To: <tglx@...utronix.de>
Cc: <frederic@...nel.org>, <peterz@...radead.org>, <oleg@...hat.com>,
        <brauner@...nel.org>, <iro@...iv.linux.org.uk>,
        <joel.granados@...nel.org>, <lorenzo.stoakes@...cle.com>,
        <linux-kernel@...r.kernel.org>, <xu.xin16@....com.cn>,
        <yang.yang29@....com.cn>
Subject: Re: [PATCH linux-next] signal: Remove outdated __send_signal references in  do_notify_parent

> > From: Fan Yu <fan.yu9@....com.cn>
> >
> > The function __send_signal was renamed to __send_signal_locked in
> 
> Just use __send_signal() and __send_signal_locked() which makes it
> entirely clear that this is about functions, so you can spare 'The
> function'. Same for the subject.

I'll use __send_signal() and __send_signal_locked() directly (removing “The function”).

> > commit 157cc18122b4 ("signal: Rename send_signal send_signal_locked"),
> > making the existing comments in do_notify_parent obsolete.
> >
> > This patch removes these outdated references to maintain code clarity
> 
> # git grep 'This patch' Documentation/process/

I'll fix it to avoid “This patch”.

> > -   /*
> > -    * Send with __send_signal as si_pid and si_uid are in the
> > -    * parent's namespaces.
> > -    */
> > +
> 
> Why are you removing the complete comment instead of just renaming the
> stale reference? 
> 
> commit 61e713bdca36 ("signal: Avoid corrupting si_pid and si_uid in
> do_notify_parent") put that comment there for a reason.

Hi tglx,

Thanks for the feedback! I agree that the patch description could be
clearer, and simply removing the comment without updating it was not
the best approach.

The comment exists for a reason, I'll clarify why __send_signal_locked
must be used and improve the description to be more precise.

Best regards,
Fan Yu