linux-kernel - Re: [PATCH] i2c: sis96x: Refactor for readability and style improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202507291702.7DUZcvW4-lkp@intel.com>
Date: Tue, 29 Jul 2025 17:38:46 +0800
From: kernel test robot <lkp@...el.com>
To: "Darshan R." <rathod.darshan.0896@...il.com>, jdelvare@...e.com,
	andi.shyti@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Darshan R." <rathod.darshan.0896@...il.com>
Subject: Re: [PATCH] i2c: sis96x: Refactor for readability and style
 improvements

Hi Darshan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on andi-shyti/i2c/i2c-host]
[also build test WARNING on linus/master v6.16 next-20250729]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Darshan-R/i2c-sis96x-Refactor-for-readability-and-style-improvements/20250728-213139
base:   https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link:    https://lore.kernel.org/r/20250728131418.9424-1-rathod.darshan.0896%40gmail.com
patch subject: [PATCH] i2c: sis96x: Refactor for readability and style improvements
config: i386-randconfig-r071-20250729 (https://download.01.org/0day-ci/archive/20250729/202507291702.7DUZcvW4-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507291702.7DUZcvW4-lkp@intel.com/

smatch warnings:
drivers/i2c/busses/i2c-sis96x.c:94 sis96x_transaction() warn: inconsistent indenting

vim +94 drivers/i2c/busses/i2c-sis96x.c

^1da177e4c3f41 Linus Torvalds 2005-04-16   75  
^1da177e4c3f41 Linus Torvalds 2005-04-16   76  /* Execute a SMBus transaction.
^1da177e4c3f41 Linus Torvalds 2005-04-16   77     int size is from SIS96x_QUICK to SIS96x_BLOCK_DATA
^1da177e4c3f41 Linus Torvalds 2005-04-16   78   */
^1da177e4c3f41 Linus Torvalds 2005-04-16   79  static int sis96x_transaction(int size)
^1da177e4c3f41 Linus Torvalds 2005-04-16   80  {
^1da177e4c3f41 Linus Torvalds 2005-04-16   81  	int temp;
^1da177e4c3f41 Linus Torvalds 2005-04-16   82  	int result = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16   83  	int timeout = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16   84  
^1da177e4c3f41 Linus Torvalds 2005-04-16   85  	dev_dbg(&sis96x_adapter.dev, "SMBus transaction %d\n", size);
^1da177e4c3f41 Linus Torvalds 2005-04-16   86  
^1da177e4c3f41 Linus Torvalds 2005-04-16   87  	/* Make sure the SMBus host is ready to start transmitting */
1f3ce966edb415 Darshan R      2025-07-28   88  	temp = sis96x_read(SMB_CNT);
^1da177e4c3f41 Linus Torvalds 2005-04-16   89  
1f3ce966edb415 Darshan R      2025-07-28   90  	if ((temp & 0x03) != 0x00) {
1f3ce966edb415 Darshan R      2025-07-28   91  		dev_dbg(&sis96x_adapter.dev, "SMBus busy (0x%02x). Resetting...\n", temp);
^1da177e4c3f41 Linus Torvalds 2005-04-16   92  
^1da177e4c3f41 Linus Torvalds 2005-04-16   93  	/* kill the transaction */
^1da177e4c3f41 Linus Torvalds 2005-04-16  @94  	sis96x_write(SMB_HOST_CNT, 0x20);
^1da177e4c3f41 Linus Torvalds 2005-04-16   95  
^1da177e4c3f41 Linus Torvalds 2005-04-16   96  	/* check it again */
1f3ce966edb415 Darshan R      2025-07-28   97  	temp = sis96x_read(SMB_CNT);
1f3ce966edb415 Darshan R      2025-07-28   98  
1f3ce966edb415 Darshan R      2025-07-28   99  	if ((temp & 0x03) != 0x00) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  100  		dev_dbg(&sis96x_adapter.dev, "Failed (0x%02x)\n", temp);
97140342e69d47 David Brownell 2008-07-14  101  		return -EBUSY;
^1da177e4c3f41 Linus Torvalds 2005-04-16  102  	} else {
^1da177e4c3f41 Linus Torvalds 2005-04-16  103  		dev_dbg(&sis96x_adapter.dev, "Successful\n");
^1da177e4c3f41 Linus Torvalds 2005-04-16  104  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  105  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  106  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki