linux-kernel - Re: [RFC PATCH 07/20] x86/virt/tdx: Expose SEAMLDR information via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIibsLNEBdK1I6pv@intel.com>
Date: Tue, 29 Jul 2025 18:00:16 +0800
From: Chao Gao <chao.gao@...el.com>
To: Xu Yilun <yilun.xu@...ux.intel.com>
CC: <linux-coco@...ts.linux.dev>, <x86@...nel.org>, <kvm@...r.kernel.org>,
	<seanjc@...gle.com>, <pbonzini@...hat.com>, <eddie.dong@...el.com>,
	<kirill.shutemov@...el.com>, <dave.hansen@...el.com>,
	<dan.j.williams@...el.com>, <kai.huang@...el.com>,
	<isaku.yamahata@...el.com>, <elena.reshetova@...el.com>,
	<rick.p.edgecombe@...el.com>, Farrah Chen <farrah.chen@...el.com>, "Kirill A.
 Shutemov" <kirill.shutemov@...ux.intel.com>, Dave Hansen
	<dave.hansen@...ux.intel.com>, Thomas Gleixner <tglx@...utronix.de>, "Ingo
 Molnar" <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, "H. Peter Anvin"
	<hpa@...or.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 07/20] x86/virt/tdx: Expose SEAMLDR information via
 sysfs

>As mentioned, TDX Connect also uses this virtual TSM device. And I tend
>to extend it to TDX guest, also make the guest TSM management run on
>the virtual device which represents the TDG calls and TDG_VP_VM calls.
>
>So I'm considering extract the common part of tdx_subsys_init() out of
>TDX host and into a separate file, e.g.
>
>---
>
>+source "drivers/virt/coco/tdx-tsm/Kconfig"
>+
> config TSM
>        bool
>diff --git a/drivers/virt/coco/Makefile b/drivers/virt/coco/Makefile
>index c0c3733be165..a54d3cb5b4e9 100644
>--- a/drivers/virt/coco/Makefile
>+++ b/drivers/virt/coco/Makefile
>@@ -10,3 +10,4 @@ obj-$(CONFIG_INTEL_TDX_GUEST) += tdx-guest/
> obj-$(CONFIG_ARM_CCA_GUEST)    += arm-cca-guest/
> obj-$(CONFIG_TSM)              += tsm-core.o
> obj-$(CONFIG_TSM_GUEST)                += guest/
>+obj-y                          += tdx-tsm/
>diff --git a/drivers/virt/coco/tdx-tsm/Kconfig b/drivers/virt/coco/tdx-tsm/Kconfig
>new file mode 100644
>index 000000000000..768175f8bb2c
>--- /dev/null
>+++ b/drivers/virt/coco/tdx-tsm/Kconfig
>@@ -0,0 +1,2 @@
>+config TDX_TSM_BUS
>+       bool
>diff --git a/drivers/virt/coco/tdx-tsm/Makefile b/drivers/virt/coco/tdx-tsm/Makefile
>new file mode 100644
>index 000000000000..09f0ac08988a
>--- /dev/null
>+++ b/drivers/virt/coco/tdx-tsm/Makefile
>@@ -0,0 +1 @@
>+obj-$(CONFIG_TDX_TSM_BUS) += tdx-tsm-bus.o
>
>---
>
>And put the tdx_subsys_init() in tdx-tsm-bus.c. We need to move host
>specific initializations out of tdx_subsys_init(), e.g. seamldr_group &
>seamldr fw upload.

Sounds good. I assume you'll update the TDX TSM framework patch* directly.
Please share the updated patch once it's ready, and I'll take care of all the
seamldr stuff.

[*]: https://lore.kernel.org/kvm/20250523095322.88774-5-chao.gao@intel.com/