linux-kernel - Re: [PATCH] rust: pci: use c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72nRJhhM6W4ue0KR+En1nYDk5KVS1dSuJkkw55jkrh_P8Q@mail.gmail.com>
Date: Tue, 29 Jul 2025 12:10:59 +0200
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Danilo Krummrich <dakr@...nel.org>
Cc: herculoxz <abhinav.ogl@...il.com>, bhelgaas@...gle.com, kwilczynski@...nel.org, 
	ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com, 
	gary@...yguo.net, bjorn3_gh@...tonmail.com, lossin@...nel.org, 
	a.hindborg@...nel.org, aliceryhl@...gle.com, tmgross@...ch.edu, 
	linux-pci@...r.kernel.org, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: pci: use c_* types via kernel prelude

On Tue, Jul 29, 2025 at 11:45 AM Danilo Krummrich <dakr@...nel.org> wrote:
>
> Something seems to be odd with the commit message, it seems some parts are
> missing.

The "ensures ABI correctness when interfacing with C code" should also
be changed -- it is true that we want to use the identifiers from the
prelude, but the ABI was fine here, since it was already using
`kernel::`.

i.e. otherwise, it would have been a fix.

Cheers,
Miguel