linux-kernel - Re: [PATCH] ASoC: amd: acp: Adjust pdm dmic gain using module parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7326f95-13fb-4f3b-86e5-69797b9235f8@sirena.org.uk>
Date: Tue, 29 Jul 2025 11:36:05 +0100
From: Mark Brown <broonie@...nel.org>
To: Mario Limonciello <mario.limonciello@....com>
Cc: Greg KH <gregkh@...uxfoundation.org>,
	Venkata Prasad Potturu <venkataprasad.potturu@....com>,
	alsa-devel@...a-project.org, Vijendar.Mukunda@....com,
	Basavaraj.Hiregoudar@....com, Sunil-kumar.Dommati@....com,
	syed.sabakareem@....com, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <linux-sound@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: amd: acp: Adjust pdm dmic gain using module
 parameter

On Tue, Jul 29, 2025 at 11:34:59AM +0530, Mario Limonciello wrote:
> On 7/28/2025 4:22 PM, Greg KH wrote:
> > On Mon, Jul 28, 2025 at 03:12:27PM +0530, Venkata Prasad Potturu wrote:

> > >   * If users do end up using it to debug and report different values
> > >     we should introduce a config knob that can have policy set by ucm.

> > Please do this properly, with a per-device setting.

> As the main purpose for this parameter is for being able to tune whether the
> property is correct, how about adding a debugfs file instead?

> AFAICT it should just be a single register write, so debugfs to read current
> value and write the debugging value seems pretty straightforward.

Or you could just go direct to making it user tunable like a normal gain
control?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)