linux-kernel - Re: [PATCH RFC bpf-next v2 1/4] fprobe: use rhltable for fprobe_ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250729104254.560beac056de20d6aebe1d55@kernel.org>
Date: Tue, 29 Jul 2025 10:42:54 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: alexei.starovoitov@...il.com, rostedt@...dmis.org,
 mathieu.desnoyers@...icios.com, hca@...ux.ibm.com, revest@...omium.org,
 linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
 bpf@...r.kernel.org
Subject: Re: [PATCH RFC bpf-next v2 1/4] fprobe: use rhltable for
 fprobe_ip_table

Hi,

I'll check it deeper, but 2 nits I found.

On Mon, 28 Jul 2025 15:22:50 +0800
Menglong Dong <menglong8.dong@...il.com> wrote:

> diff --git a/kernel/trace/fprobe.c b/kernel/trace/fprobe.c
> index ba7ff14f5339..640a0c47fc76 100644
> --- a/kernel/trace/fprobe.c
> +++ b/kernel/trace/fprobe.c
> @@ -12,6 +12,7 @@
>  #include <linux/mutex.h>
>  #include <linux/slab.h>
>  #include <linux/sort.h>
> +#include <linux/rhashtable.h>

nit: Can you sort this alphabetically?

[...]
> @@ -249,9 +251,10 @@ static inline int __fprobe_kprobe_handler(unsigned long ip, unsigned long parent
>  static int fprobe_entry(struct ftrace_graph_ent *trace, struct fgraph_ops *gops,
>  			struct ftrace_regs *fregs)
>  {
> -	struct fprobe_hlist_node *node, *first;
> +	struct fprobe_hlist_node *node;
>  	unsigned long *fgraph_data = NULL;
>  	unsigned long func = trace->func;
> +	struct rhlist_head *head, *pos;

nit: Can you sort this as reverse Christmas tree? (like as below)

>  	unsigned long *fgraph_data = NULL;
>  	unsigned long func = trace->func;
> +	struct fprobe_hlist_node *node;
> +	struct rhlist_head *head, *pos;


>  	unsigned long ret_ip;
>  	int reserved_words;
>  	struct fprobe *fp;

Thank you,

-- 
Masami Hiramatsu (Google) <mhiramat@...nel.org>