linux-kernel - Re: [PATCH v7 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b7bc371-576b-4a4a-88a4-a4ed47d97778@oss.qualcomm.com>
Date: Tue, 29 Jul 2025 17:41:26 +0530
From: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
To: Violet <violet@....tools>, Konrad Dybcio <konradybcio@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>, linux-kernel@...r.kernel.org,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v7 2/2] arm64: dts: qcom: add initial support for Samsung
 Galaxy S22



On 7/29/2025 5:33 PM, Violet wrote:
> Add new device support for the Samsung Galaxy S22 (SM-S901E) phone
> 
> What works:
> - SimpleFB
> - USB
> 
> Signed-off-by: Violet <violet@....tools>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   arch/arm64/boot/dts/qcom/Makefile             |   1 +
>   .../boot/dts/qcom/sm8450-samsung-r0q.dts      | 147 ++++++++++++++++++
>   2 files changed, 148 insertions(+)
>   create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> 

[...]

> +
> +&tlmm {
> +	gpio-reserved-ranges = <36 4>; /* SPI (not linked to anything) */
> +};
> +
> +&usb_1 {
> +	/* Keep USB 2.0 only for now */
> +	qcom,select-utmi-as-pipe-clk;
> +
> +	status = "okay";
> +}; > +
> +&usb_1_dwc3 {
> +	dr_mode = "peripheral";
> +	maximum-speed = "high-speed";
> +	/* Remove USB3 phy */
> +	phys = <&usb_1_hsphy>;
> +	phy-names = "usb2-phy";
> +};
> +

Hi Violet,

  The usb node has been flattened recently. Its not merged yet, but it 
was acked: [1]. Can you rebase your changes on top of this patch [1].

[1]: 
https://lore.kernel.org/all/20250715052739.3831549-3-krishna.kurapati@oss.qualcomm.com/

Regards,
Krishna,

> +&usb_1_hsphy {
> +	vdda-pll-supply = <&vreg_l5b_0p88>;
> +	vdda18-supply = <&vreg_l1c_1p8>;
> +	vdda33-supply = <&vreg_l2b_3p07>;
> +
> +	status = "okay";
> +};