linux-kernel - Re: [PATCH] jfs: fix metapage reference count leak in dbAllocCtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d908a98-bfb1-4008-9944-c33dc035d42f@web.de>
Date: Tue, 29 Jul 2025 16:23:26 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Zheng Yu <zheng.yu@...thwestern.edu>,
 jfs-discussion@...ts.sourceforge.net, Dave Kleikamp <shaggy@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Edward Adam Davis <eadavis@...com>,
 Jeongjun Park <aha310510@...il.com>,
 Nihar Chaithanya <niharchaithanya@...il.com>,
 Rand Deeb <rand.sec96@...il.com>, Vasiliy Kovalev <kovalev@...linux.org>,
 Zheng Yu <zheng.yu@...thwestern.edu>
Subject: Re: [PATCH] jfs: fix metapage reference count leak in dbAllocCtl

…
> +++ b/fs/jfs/jfs_dmap.c
> @@ -1809,8 +1809,10 @@ dbAllocCtl(struct bmap * bmp, s64 nblocks, int l2nb, s64 blkno, s64 * results)
>  			return -EIO;
>  		dp = (struct dmap *) mp->data;
>  
> -		if (dp->tree.budmin < 0)
> +		if (dp->tree.budmin < 0) {
> +			release_metapage(mp);
>  			return -EIO;
> +		}
…

Would it be a bit nicer to use an additional label for this case?

			rc = -EIO;
			goto release_metapage;


Regards,
Markus