linux-kernel - Re: [PATCH v2 2/2] selftests/seccomp: Add a test for the WAIT_KILLABLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBOOW06CYM2U.11R0PDE4QNQK9@shadowice.org>
Date: Tue, 29 Jul 2025 18:45:46 +0200
From: "Johannes Nixdorf" <mixi@...dowice.org>
To: "Kees Cook" <kees@...nel.org>, "Johannes Nixdorf" <johannes@...dorf.dev>
Cc: "Andy Lutomirski" <luto@...capital.net>, "Will Drewry"
 <wad@...omium.org>, "Sargun Dhillon" <sargun@...gun.me>, "Shuah Khan"
 <shuah@...nel.org>, <linux-kernel@...r.kernel.org>, "Ali Polatel"
 <alip@...sswob.org>, <linux-kselftest@...r.kernel.org>,
 <bpf@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] selftests/seccomp: Add a test for the
 WAIT_KILLABLE_RECV fast reply race

On Tue Jul 29, 2025 at 3:07 AM CEST, Kees Cook wrote:
> On Fri, Jul 25, 2025 at 06:31:19PM +0200, Johannes Nixdorf wrote:
>> +		struct itimerval timer = {
>> +			.it_value = { .tv_usec = 1000 },
>> +			.it_interval = { .tv_usec = 1000 },
>> +		};
>
> To get this to build, I needed to add a sys/time.h include:
>
> diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
> index b24d0cbe88b4..fc4910d35342 100644
> --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
> +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
> @@ -24,6 +24,7 @@
>  #include <linux/filter.h>
>  #include <sys/prctl.h>
>  #include <sys/ptrace.h>
> +#include <sys/time.h>
>  #include <sys/user.h>
>  #include <linux/prctl.h>
>  #include <linux/ptrace.h>
>
> But, with that, yes, I can confirm the race and the fix. Thank you!
> I can fix that up locally.

Sounds good. The change looks correct to me as well.

>
> -Kees

Best regards,
Johannes