linux-kernel - Re: [PATCH] fs/Kconfig: Enable HUGETLBFS only if ARCH_SUPPORTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c37a89e-cfc7-4d4c-89e1-1b3f1217b11e@csgroup.eu>
Date: Tue, 29 Jul 2025 17:52:51 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Andrew Morton <akpm@...ux-foundation.org>, Borislav Petkov <bp@...en8.de>
Cc: Anshuman Khandual <anshuman.khandual@....com>, linux-mm@...ck.org,
 "David S. Miller" <davem@...emloft.net>, Thomas Gleixner
 <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
 sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] fs/Kconfig: Enable HUGETLBFS only if
 ARCH_SUPPORTS_HUGETLBFS



Le 29/07/2025 à 17:50, Christophe Leroy a écrit :
> 
> 
> Le 15/07/2025 à 02:31, Andrew Morton a écrit :
>> On Mon, 14 Jul 2025 11:49:09 +0200 Borislav Petkov <bp@...en8.de> wrote:
>>
>>> On Mon, Jul 14, 2025 at 08:05:31AM +0530, Anshuman Khandual wrote:
>>>> The original first commit had added 'BROKEN', although currently there
>>>> are no explanations about it in the tree.
>>>
>>> commit c0dde7404aff064bff46ae1d5f1584d38e30c3bf
>>> Author: Linus Torvalds <torvalds@...e.osdl.org>
>>> Date:   Sun Aug 17 21:23:57 2003 -0700
>>>
>>>      Add CONFIG_BROKEN (default 'n') to hide known-broken drivers.
>>
>> Thanks.  That was unkind of someone.  How's this?
>>
>>
>> From: Andrew Morton <akpm@...ux-foundation.org>
>> Subject: init/Kconfig: restore CONFIG_BROKEN help text
>> Date: Mon Jul 14 05:20:02 PM PDT 2025
>>
>> Linus added it in 2003, it later was removed.  Put it back.
> 
> Was removed by:
> 
> commit 3be71ba84f17f39131900f44e8ef513c696a5b11
> Author: Linus Torvalds <torvalds@...e.osdl.org>
> Date:   Mon Sep 1 21:30:14 2003 -0700
> 
>      Instead of asking for "broken drivers", ask for a "clean compile".
> 
>      This makes "allyesconfig" do a better job.

Which was then later removed by:

commit 3636641bb2c7a806c1099ca092ec8cd180063f9b
Author: Adrian Bunk <bunk@...sta.de>
Date:   Fri Feb 3 03:04:00 2006 -0800

     [PATCH] don't allow users to set CONFIG_BROKEN=y

     Do not allow people to create configurations with CONFIG_BROKEN=y.

     The sole reason for CONFIG_BROKEN=y would be if you are working on 
fixing a
     broken driver, but in this case editing the Kconfig file is trivial.

     Never ever should a user enable CONFIG_BROKEN.

     Signed-off-by: Adrian Bunk <bunk@...sta.de>
     Signed-off-by: Andrew Morton <akpm@...l.org>
     Signed-off-by: Linus Torvalds <torvalds@...l.org>

diff --git a/init/Kconfig b/init/Kconfig
index b9923b1434a2f..8b7abae87bf9c 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -31,19 +31,8 @@ config EXPERIMENTAL
  	  you say Y here, you will be offered the choice of using features or
  	  drivers that are currently considered to be in the alpha-test phase.

-config CLEAN_COMPILE
-	bool "Select only drivers expected to compile cleanly" if EXPERIMENTAL
-	default y
-	help
-	  Select this option if you don't even want to see the option
-	  to configure known-broken drivers.
-
-	  If unsure, say Y
-
  config BROKEN
  	bool
-	depends on !CLEAN_COMPILE
-	default y

  config BROKEN_ON_SMP
  	bool