linux-kernel - Re: [PATCH] nvmet: Remove unnecessary assignment to ret in nvmet_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250730161755.GA1177361-mkhalfella@purestorage.com>
Date: Wed, 30 Jul 2025 09:17:55 -0700
From: Mohamed Khalfella <mkhalfella@...estorage.com>
To: Christoph Hellwig <hch@....de>
Cc: Sagi Grimberg <sagi@...mberg.me>, Chaitanya Kulkarni <kch@...dia.com>,
	Keith Busch <kbusch@...nel.org>, Hannes Reinecke <hare@...nel.org>,
	Nilay Shroff <nilay@...ux.ibm.com>,
	Randy Jennings <randyj@...estorage.com>,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmet: Remove unnecessary assignment to ret in
 nvmet_ns_enable()

On 2025-07-30 17:53:35 +0200, Christoph Hellwig wrote:
> On Fri, Jul 25, 2025 at 04:06:39PM -0700, Mohamed Khalfella wrote:
> > Commit 74d16965d7ac ("nvmet-loop: avoid using mutex in IO hotpath")
> > moved checking maximum number of namespaces in subsystem from
> > nvmet_ns_enable() to nvmet_ns_alloc(). The assignment to ret in
> > nvmet_ns_enable() is no longer needed, remove it.
> 
> This assignment already is gone in the current tree.
> 

Yep, it looks like it has been removed in commit 2e7dd5c1a8ae ("nvmet: remove
redundant assignment of error code in nvmet_ns_enable()").

Thanks,