linux-kernel - Re: [PATCH v2 1/5] blk-mq-sched: introduce high level elevator lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e07ce691-c298-4cb4-8ac3-35c8a8beaea4@acm.org>
Date: Wed, 30 Jul 2025 10:19:07 -0700
From: Bart Van Assche <bvanassche@....org>
To: Yu Kuai <yukuai1@...weicloud.com>, dlemoal@...nel.org, hare@...e.de,
 jack@...e.cz, tj@...nel.org, josef@...icpanda.com, axboe@...nel.dk,
 yukuai3@...wei.com
Cc: cgroups@...r.kernel.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 johnny.chenyi@...wei.com
Subject: Re: [PATCH v2 1/5] blk-mq-sched: introduce high level elevator lock

On 7/30/25 1:22 AM, Yu Kuai wrote:
> +		if (sq_sched)
> +			spin_lock(&e->lock);
>   		rq = e->type->ops.dispatch_request(hctx);
> +		if (sq_sched)
> +			spin_unlock(&e->lock);

The above will confuse static analyzers. Please change it into something
like the following:

if (blk_queue_sq_sched(q)) {
	spin_lock(&e->lock);
	rq = e->type->ops.dispatch_request(hctx);
	spin_unlock(&e->lock);
} else {
	rq = e->type->ops.dispatch_request(hctx);
}

Otherwise this patch looks good to me.

Thanks,

Bart.