linux-kernel - Re: [PATCH v2] platform/x86: Add WMI driver for Redmibook keyboard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26cdd07b-7b5c-4636-99c2-6c078c6a48bc@foxido.dev>
Date: Wed, 30 Jul 2025 20:37:12 +0300
From: Gladyshev Ilya <foxido@...ido.dev>
To: Armin Wolf <W_Armin@....de>
Cc: linux-input@...r.kernel.org, nikita.nikita.krasnov@...il.com,
 Hans de Goede <hansg@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: Add WMI driver for Redmibook keyboard.

Thx for review

On 7/30/25 19:33, Armin Wolf wrote:
>> +
>> +    if (obj->type != ACPI_TYPE_BUFFER) {
>> +        dev_err(&wdev->dev, "Bad response type %u\n", obj->type);
>> +        return;
>> +    }
>> +
>> +    if (obj->buffer.length != 32) {
> 
> Please also accept oversized buffers.
>
Sorry if this is a stupid question, but isn't any size other than 32 a 
sign of a firmware bug?

>> +
>> +    /* AI key quirk */
>> +    if (entry->keycode == KEY_ASSISTANT) {
>> +        value = !(payload & AI_KEY_VALUE_MASK);
> 
> I would rather check the payload for 0x00011901 here.
Personally I prefer to think about it as "some value encoded in payload" 
rather than "is it AI button release payload?", because in the latter 
case alternatives are more unclear. It's just a preference, btw, would 
fix if you insist.

--
Gladyshev Ilya