linux-kernel - Re: [PATCH v2 1/2] perf topdown: Use attribute to see an event is a topdown metic or slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aIpg6OsDZNeG1mRX@google.com>
Date: Wed, 30 Jul 2025 11:14:00 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: "Mi, Dapeng" <dapeng1.mi@...ux.intel.com>
Cc: Ian Rogers <irogers@...gle.com>,
	Thomas Falcon <thomas.falcon@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	"Liang, Kan" <kan.liang@...ux.intel.com>,
	Ravi Bangoria <ravi.bangoria@....com>,
	James Clark <james.clark@...aro.org>,
	Weilin Wang <weilin.wang@...el.com>,
	Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH v2 1/2] perf topdown: Use attribute to see an event is a
 topdown metic or slots

Hello,

On Tue, Jul 29, 2025 at 11:21:32AM +0800, Mi, Dapeng wrote:
> 
> On 7/23/2025 9:03 AM, Namhyung Kim wrote:
> > On Fri, Jul 18, 2025 at 06:27:49AM -0700, Ian Rogers wrote:
> >> The string comparisons were overly broad and could fire for the
> >> incorrect PMU and events. Switch to using the config in the attribute
> >> then add a perf test to confirm the attribute config values match
> >> those of parsed events of that name and don't match others. This
> >> exposed matches for slots events that shouldn't have matched as the
> >> slots fixed counter event, such as topdown.slots_p.
> >>
> >> Fixes: fbc798316bef ("perf x86/topdown: Refine helper arch_is_topdown_metrics()")
> >> Signed-off-by: Ian Rogers <irogers@...gle.com>
> > Dapeng, are you ok with this (or Ian's TMA fix v3 below)?
> >
> > https://lore.kernel.org/r/20250719030517.1990983-1-irogers@google.com
> 
> Sorry for late response (Just back from vacation). The patches look good to
> me. I tested these patches on Sapphire Rapids and Panther Lake, no issue is
> found. Thanks. 

Thanks for testing this!
Namhyung