linux-kernel - Re: [PATCH v14 4/4] rust: support large alignments in allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBPO1RQMZDH2.2WFOZO0X4DODN@kernel.org>
Date: Wed, 30 Jul 2025 22:18:57 +0200
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Vitaly Wool" <vitaly.wool@...sulko.se>
Cc: <linux-mm@...ck.org>, <akpm@...ux-foundation.org>,
 <linux-kernel@...r.kernel.org>, "Uladzislau Rezki" <urezki@...il.com>,
 "Alice Ryhl" <aliceryhl@...gle.com>, "Vlastimil Babka" <vbabka@...e.cz>,
 <rust-for-linux@...r.kernel.org>, "Lorenzo Stoakes"
 <lorenzo.stoakes@...cle.com>, "Liam R . Howlett" <Liam.Howlett@...cle.com>,
 "Kent Overstreet" <kent.overstreet@...ux.dev>,
 <linux-bcachefs@...r.kernel.org>, <bpf@...r.kernel.org>, "Herbert Xu"
 <herbert@...dor.apana.org.au>, "Jann Horn" <jannh@...gle.com>, "Pedro
 Falcato" <pfalcato@...e.de>
Subject: Re: [PATCH v14 4/4] rust: support large alignments in allocations

On Wed Jul 30, 2025 at 9:21 PM CEST, Vitaly Wool wrote:
> diff --git a/rust/kernel/alloc/allocator_test.rs b/rust/kernel/alloc/allocator_test.rs
> index d19c06ef0498..17b27c6e9e37 100644
> --- a/rust/kernel/alloc/allocator_test.rs
> +++ b/rust/kernel/alloc/allocator_test.rs
> @@ -40,6 +40,7 @@ unsafe fn realloc(
>          layout: Layout,
>          old_layout: Layout,
>          flags: Flags,
> +        nid: NumaNode,
>      ) -> Result<NonNull<[u8]>, AllocError> {
>          let src = match ptr {
>              Some(src) => {

I think this hunk should be on patch 3.

Also, don't you see a warning when running the rusttest target? I think it has
to be _nid, given that the argument is unused.