linux-kernel - Re: [PATCH v11 2/4] leds: add basic support for TI/National Semiconductor LP5812 LED Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250730040839.125683-1-trannamatk@gmail.com>
Date: Wed, 30 Jul 2025 11:08:39 +0700
From: Nam Tran <trannamatk@...il.com>
To: lee@...nel.org,
	krzk+dt@...nel.org
Cc: pavel@...nel.org,
	rdunlap@...radead.org,
	christophe.jaillet@...adoo.fr,
	robh@...nel.org,
	conor+dt@...nel.org,
	corbet@....net,
	linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org
Subject: Re: [PATCH v11 2/4] leds: add basic support for TI/National Semiconductor LP5812 LED Driver

On Tue, 29 Jul 2025, Krzysztof Kozlowski wrote:

> On 28/07/2025 08:58, Nam Tran wrote:
> 
> ...
> 
> > +MODULE_DEVICE_TABLE(of, of_lp5812_match);
> > +
> > +static struct i2c_driver lp5812_driver = {
> > +	.driver = {
> > +		.name   = "lp5812",
> > +		.of_match_table = of_match_ptr(of_lp5812_match),
> 
> v11 was okay here... now you introduced errors.

Thank you for pointing that out.

You're absolutely right.
Since the LP5812 driver is DT-only and doesn't support non-DT probing,
using of_match_ptr() is unnecessary and potentially incorrect.

I'll drop of_match_ptr() and directly assign the of_match_table.

Thanks again for the review!

Best regards,
Nam Tran