linux-kernel - Re: [PATCH] iio: imu: bmi270: Match ACPI ID found on newer GPD firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vc2K3AmPhwme3+7cCGwDTA6V+4Ug8f++iFr8gCThCOnQw@mail.gmail.com>
Date: Wed, 30 Jul 2025 22:57:32 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: liziyao@...ontech.com
Cc: Alex Lanzano <lanzano.alex@...il.com>, Jonathan Cameron <jic23@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Yao Zi <ziyao@...root.org>, WangYuli <wangyuli@...ontech.com>, 
	Jun Zhan <zhanjun@...ontech.com>
Subject: Re: [PATCH] iio: imu: bmi270: Match ACPI ID found on newer GPD firmware

On Wed, Jul 30, 2025 at 2:56 PM Cryolitia PukNgae via B4 Relay
<devnull+liziyao.uniontech.com@...nel.org> wrote:
>
> From: Cryolitia PukNgae <liziyao@...ontech.com>
>
> Some GPD devices ship a buggy firmware that describes on-device BMI260
> with ACPI ID "BMI0160". Since this is fixed in BIOS update v0.40,
> let's match the correct ID to detect the device. The buggy ID "BMI0160"
> is kept as well to maintain compatibility with older firmwares.

No, it's not true. See below why,

> ---
> Some GPD devices ship a buggy firmware that describes on-device BMI260
> with ACPI ID "BMI0160". Since this is fixed in BIOS update v0.40[1],
> let's match the correct ID to detect the device. The buggy ID "BMI0160"
> is kept as well to maintain compatibility with older firmwares.
>
> Link: http://download.softwincn.com/WIN%20Max%202024/Max2-7840-BIOS-V0.41.zip
>
> [1]. See the update nodes in the archive file above

Yeah... I think you need one more attempt to fix it right.

...

>  static const struct acpi_device_id bmi270_acpi_match[] = {
>         /* GPD Win Mini, Aya Neo AIR Pro, OXP Mini Pro, etc. */
>         { "BMI0160",  (kernel_ulong_t)&bmi260_chip_info },

Unbelievable! How is the above supposed to work? Do we have DMI quirks
in both drivers (bmi160 and bmi270)?

> +       /* GPD Win Max 2 2023(sincice BIOS v0.40), etc. */
> +       { "BMI0260",  (kernel_ulong_t)&bmi260_chip_info },

For the record this is incorrect ACPI ID, nor PNP ID for Bosh, unless
I missed that https://www.bensonmedical.com/ is bought by Bosh or part
of the groups of the companies.,

>         { }
>  };

Can you work with Bosh to resolve this as soon as possible and use a
real Bosh ACPI ID (BOSCxxxx) or PNP ID (BSGxxxx)?
Also, each ACPI ID adding patch (when it's incorrect) must provide a
DSDT excerpt in the commit message to show this. Ideally this also
should be confirmed by the vendor of the device (GPD) that the ID is
incorrect and a correct one needs to be used.

-- 
With Best Regards,
Andy Shevchenko