linux-kernel - [PATCH] scsi: buslogic: mark blogic_pci_tbl as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250730214451.441025-1-arnd@kernel.org>
Date: Wed, 30 Jul 2025 23:44:47 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: Khalid Aziz <khalid@...ehiking.org>,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Alexey Gladkov <legion@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>,
	Damien Le Moal <dlemoal@...nel.org>,
	Geoff Levand <geoff@...radead.org>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Bart Van Assche <bvanassche@....org>,
	linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] scsi: buslogic: mark blogic_pci_tbl as __maybe_unused

From: Arnd Bergmann <arnd@...db.de>

A previous patch removed an #ifdef check around the array definition, but
this is not actually used when the driver is built-in, and now causes
a warning when -Wunused-const-variable is set:

drivers/scsi/BusLogic.c:3727:35: error: 'blogic_pci_tbl' defined but not used [-Werror=unused-const-variable=]

Mark it as __maybe_unused for this configuration.

Ideally this should be fixed instead by using the array as part of
a pci_driver definition, instead of the linux-2.4 style manual bus
scan.

Fixes: 204689f0ea20 ("scsi: Always define blogic_pci_tbl structure")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
There are only a handful of unused const variables left in the kernel,
and I would like to turn that warning on by default when they are
all gone.
---
 drivers/scsi/BusLogic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index 08e12a3d6703..82597bd96525 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -3724,7 +3724,7 @@ __setup("BusLogic=", blogic_setup);
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
 	{ }
 };*/
-static const struct pci_device_id blogic_pci_tbl[] = {
+static const struct pci_device_id blogic_pci_tbl[] __maybe_unused = {
 	{PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER_NC)},
 	{PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_FLASHPOINT)},
-- 
2.39.5