linux-kernel - Re: [PATCH v7 1/2] Drivers: hv: Export some symbols for mshv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMvTesAzY+x_2_40xji6_g6Uquf4j1HmREb1vH9kT4fNzuLY1Q@mail.gmail.com>
Date: Wed, 30 Jul 2025 13:15:29 +0800
From: Tianyu Lan <ltykernel@...il.com>
To: Naman Jain <namjain@...ux.microsoft.com>
Cc: "K . Y . Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, 
	Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, 
	Michael Kelley <mhklinux@...look.com>, Roman Kisel <romank@...ux.microsoft.com>, 
	Anirudh Rayabharam <anrayabh@...ux.microsoft.com>, Saurabh Sengar <ssengar@...ux.microsoft.com>, 
	Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>, 
	Nuno Das Neves <nunodasneves@...ux.microsoft.com>, ALOK TIWARI <alok.a.tiwari@...cle.com>, 
	linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org
Subject: Re: [PATCH v7 1/2] Drivers: hv: Export some symbols for mshv_vtl

On Tue, Jul 29, 2025 at 1:15 PM Naman Jain <namjain@...ux.microsoft.com> wrote:
>
> MSHV_VTL driver is going to be introduced, which is supposed to
> provide interface for Virtual Machine Monitors (VMMs) to control
> Virtual Trust Level (VTL). Export the symbols needed
> to make it work (vmbus_isr, hv_context and hv_post_message).
>
> Co-developed-by: Roman Kisel <romank@...ux.microsoft.com>
> Signed-off-by: Roman Kisel <romank@...ux.microsoft.com>
> Co-developed-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> Signed-off-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> Reviewed-by: Roman Kisel <romank@...ux.microsoft.com>
> Reviewed-by: Saurabh Sengar <ssengar@...ux.microsoft.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202506110544.q0NDMQVc-lkp@intel.com/
> Signed-off-by: Naman Jain <namjain@...ux.microsoft.com>
> ---
>  drivers/hv/hv.c           | 3 +++
>  drivers/hv/hyperv_vmbus.h | 1 +
>  drivers/hv/vmbus_drv.c    | 4 +++-
>  3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
> index b14c5f9e0ef2..b16e94daa270 100644
> --- a/drivers/hv/hv.c
> +++ b/drivers/hv/hv.c
> @@ -18,6 +18,7 @@
>  #include <linux/clockchips.h>
>  #include <linux/delay.h>
>  #include <linux/interrupt.h>
> +#include <linux/export.h>
>  #include <clocksource/hyperv_timer.h>
>  #include <asm/mshyperv.h>
>  #include <linux/set_memory.h>
> @@ -25,6 +26,7 @@
>
>  /* The one and only */
>  struct hv_context hv_context;
> +EXPORT_SYMBOL_GPL(hv_context);
>
>  /*
>   * hv_init - Main initialization routine.
> @@ -95,6 +97,7 @@ int hv_post_message(union hv_connection_id connection_id,
>
>         return hv_result(status);
>  }
> +EXPORT_SYMBOL_GPL(hv_post_message);
>
>  int hv_synic_alloc(void)
>  {
> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
> index 0b450e53161e..b61f01fc1960 100644
> --- a/drivers/hv/hyperv_vmbus.h
> +++ b/drivers/hv/hyperv_vmbus.h
> @@ -32,6 +32,7 @@
>   */
>  #define HV_UTIL_NEGO_TIMEOUT 55
>
> +void vmbus_isr(void);
>
>  /* Definitions for the monitored notification facility */
>  union hv_monitor_trigger_group {
> diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
> index 2ed5a1e89d69..a366365f2c49 100644
> --- a/drivers/hv/vmbus_drv.c
> +++ b/drivers/hv/vmbus_drv.c
> @@ -36,6 +36,7 @@
>  #include <linux/syscore_ops.h>
>  #include <linux/dma-map-ops.h>
>  #include <linux/pci.h>
> +#include <linux/export.h>
>  #include <clocksource/hyperv_timer.h>
>  #include <asm/mshyperv.h>
>  #include "hyperv_vmbus.h"
> @@ -1306,7 +1307,7 @@ static void vmbus_chan_sched(struct hv_per_cpu_context *hv_cpu)
>         }
>  }
>
> -static void vmbus_isr(void)
> +void vmbus_isr(void)
>  {
>         struct hv_per_cpu_context *hv_cpu
>                 = this_cpu_ptr(hv_context.cpu_context);
> @@ -1329,6 +1330,7 @@ static void vmbus_isr(void)
>
>         add_interrupt_randomness(vmbus_interrupt);
>  }
> +EXPORT_SYMBOL_GPL(vmbus_isr);
>
>  static irqreturn_t vmbus_percpu_isr(int irq, void *dev_id)
>  {
> --
> 2.34.1
>
>

Reviewed-by: Tianyu Lan <tiala@...rosoft.com>
-- 
Thanks
Tianyu Lan